lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 23 Jul 2020 01:10:34 +0300 From: Alexander Lobakin <alobakin@...vell.com> To: "David S. Miller" <davem@...emloft.net>, Jakub Kicinski <kuba@...nel.org> CC: Alexander Lobakin <alobakin@...vell.com>, Igor Russkikh <irusskikh@...vell.com>, Michal Kalderon <michal.kalderon@...vell.com>, "Ariel Elior" <aelior@...vell.com>, Denis Bolotin <denis.bolotin@...vell.com>, "Doug Ledford" <dledford@...hat.com>, Jason Gunthorpe <jgg@...pe.ca>, "Alexei Starovoitov" <ast@...nel.org>, Daniel Borkmann <daniel@...earbox.net>, "Jesper Dangaard Brouer" <hawk@...nel.org>, John Fastabend <john.fastabend@...il.com>, Martin KaFai Lau <kafai@...com>, Song Liu <songliubraving@...com>, "Yonghong Song" <yhs@...com>, Andrii Nakryiko <andriin@...com>, KP Singh <kpsingh@...omium.org>, <GR-everest-linux-l2@...vell.com>, <netdev@...r.kernel.org>, <bpf@...r.kernel.org>, <linux-rdma@...r.kernel.org>, <linux-kernel@...r.kernel.org> Subject: [PATCH v2 net-next 04/15] qed: prevent possible double-frees of the chains Zero-initialize chain on qed_chain_free(), so it couldn't be freed twice and provoke undefined behaviour. Signed-off-by: Alexander Lobakin <alobakin@...vell.com> Signed-off-by: Igor Russkikh <irusskikh@...vell.com> Signed-off-by: Michal Kalderon <michal.kalderon@...vell.com> --- drivers/net/ethernet/qlogic/qed/qed_chain.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/net/ethernet/qlogic/qed/qed_chain.c b/drivers/net/ethernet/qlogic/qed/qed_chain.c index bab02ff32514..917b783433f7 100644 --- a/drivers/net/ethernet/qlogic/qed/qed_chain.c +++ b/drivers/net/ethernet/qlogic/qed/qed_chain.c @@ -92,8 +92,10 @@ void qed_chain_free(struct qed_dev *cdev, struct qed_chain *chain) qed_chain_free_pbl(cdev, chain); break; default: - break; + return; } + + qed_chain_init_mem(chain, NULL, 0); } static int -- 2.25.1
Powered by blists - more mailing lists