linux-kernel - Re: [PATCH -next] soc: qcom: geni: Fix unused lable warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 21 Jul 2020 21:29:09 -0700
From:   Bjorn Andersson <bjorn.andersson@...aro.org>
To:     YueHaibing <yuehaibing@...wei.com>
Cc:     agross@...nel.org, akashast@...eaurora.org, mka@...omium.org,
        linux-arm-msm@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH -next] soc: qcom: geni: Fix unused lable warning

On Tue 21 Jul 19:06 PDT 2020, YueHaibing wrote:

> If CONFIG_SERIAL_EARLYCON is not set, gcc warns this:
> 
> drivers/soc/qcom/qcom-geni-se.c: In function ‘geni_se_probe’:
> drivers/soc/qcom/qcom-geni-se.c:914:1: warning: label ‘exit’ defined but not used [-Wunused-label]
>  exit:
>  ^~~~
> 
> Fixes: 048eb908a1f2 ("soc: qcom-geni-se: Add interconnect support to fix earlycon crash")

Reviewed-by: Bjorn Andersson <bjorn.andersson@...aro.org>

> Signed-off-by: YueHaibing <yuehaibing@...wei.com>

and applied.

Thanks,
Bjorn

> ---
>  drivers/soc/qcom/qcom-geni-se.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/soc/qcom/qcom-geni-se.c b/drivers/soc/qcom/qcom-geni-se.c
> index 3413129d73ef..d0e4f520cff8 100644
> --- a/drivers/soc/qcom/qcom-geni-se.c
> +++ b/drivers/soc/qcom/qcom-geni-se.c
> @@ -910,8 +910,8 @@ static int geni_se_probe(struct platform_device *pdev)
>  	if (of_get_compatible_child(pdev->dev.of_node, "qcom,geni-debug-uart"))
>  		earlycon_wrapper = wrapper;
>  	of_node_put(pdev->dev.of_node);
> -#endif
>  exit:
> +#endif
>  	dev_set_drvdata(dev, wrapper);
>  	dev_dbg(dev, "GENI SE Driver probed\n");
>  	return devm_of_platform_populate(dev);
> -- 
> 2.17.1
> 
>