linux-kernel - Re: [PATCH] kernel: add a kernel

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20200722061044.GA24678@lst.de>
Date:   Wed, 22 Jul 2020 08:10:44 +0200
From:   Christoph Hellwig <hch@....de>
To:     Andrew Morton <akpm@...ux-foundation.org>
Cc:     Christoph Hellwig <hch@....de>, mcgrof@...nel.org,
        linux-kernel@...r.kernel.org,
        "Eric W. Biederman" <ebiederm@...ssion.com>
Subject: Re: [PATCH] kernel: add a kernel_wait helper

On Tue, Jul 21, 2020 at 02:18:38PM -0700, Andrew Morton wrote:
> On Tue, 21 Jul 2020 15:04:49 +0200 Christoph Hellwig <hch@....de> wrote:
> 
> > Add a helper that waits for a pid and stores the status in the passed
> > in kernel pointer.  Use it to fix the usage of kernel_wait4 in
> > call_usermodehelper_exec_sync that only happens to work due to the
> > implicit set_fs(KERNEL_DS) for kernel threads.
> 
> I guess it's cleaner, although it's a bit sad to be adding code to
> address a non-problem.
> 
> Did you consider a simpler kernel_wait() which just wraps a
> set_fs(KERNEL_DS) around a call to kernel_wait4()?

I'm about to kill set_fs and this one of the last users in linux-next..