linux-kernel - RE: [PATCH v6 0/5] scsi: ufs: Add Host Performance Booster Support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <SN6PR04MB4640A603AE3973E5738ED3DEFC790@SN6PR04MB4640.namprd04.prod.outlook.com>
Date:   Wed, 22 Jul 2020 06:18:21 +0000
From:   Avri Altman <Avri.Altman@....com>
To:     "Martin K. Petersen" <martin.petersen@...cle.com>
CC:     Alim Akhtar <alim.akhtar@...sung.com>,
        "daejun7.park@...sung.com" <daejun7.park@...sung.com>,
        "jejb@...ux.ibm.com" <jejb@...ux.ibm.com>,
        "asutoshd@...eaurora.org" <asutoshd@...eaurora.org>,
        "beanhuo@...ron.com" <beanhuo@...ron.com>,
        "stanley.chu@...iatek.com" <stanley.chu@...iatek.com>,
        "cang@...eaurora.org" <cang@...eaurora.org>,
        "bvanassche@....org" <bvanassche@....org>,
        "tomas.winkler@...el.com" <tomas.winkler@...el.com>,
        "linux-scsi@...r.kernel.org" <linux-scsi@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        'Sang-yoon Oh' <sangyoon.oh@...sung.com>,
        'Sung-Jun Park' <sungjun07.park@...sung.com>,
        'yongmyung lee' <ymhungry.lee@...sung.com>,
        'Jinyoung CHOI' <j-young.choi@...sung.com>,
        'Adel Choi' <adel.choi@...sung.com>,
        'BoRam Shin' <boram.shin@...sung.com>
Subject: RE: [PATCH v6 0/5] scsi: ufs: Add Host Performance Booster Support

> 
> Avri,
> 
> > Martin - Can we move forward with this one?
> 
>   CHECK   drivers/scsi/ufs/ufshcd-pltfrm.c
> drivers/scsi/ufs/ufsfeature.c:90:20: warning: symbol 'ufshpb_dev_type' was
> not declared. Should it be static?
> drivers/scsi/ufs/ufsfeature.c:104:17: warning: symbol 'ufsf_bus_type' was not
> declared. Should it be static?
>   CC [M]  drivers/scsi/ufs/ufsfeature.o
>   CC [M]  drivers/scsi/ufs/ufs_bsg.o
>   CC [M]  drivers/scsi/ufs/ufs-sysfs.o
> drivers/scsi/ufs/ufshpb.c:18:14: warning: symbol 'ufshpb_host_map_kbytes'
> was not declared. Should it be static?
> drivers/scsi/ufs/ufshpb.c:793:28: warning: mixing different enum types:
> drivers/scsi/ufs/ufshpb.c:793:28:    unsigned int enum HPB_RGN_STATE
> drivers/scsi/ufs/ufshpb.c:793:28:    unsigned int enum HPB_SRGN_STATE
>   CC [M]  drivers/scsi/ufs/ufshcd.o
> drivers/scsi/ufs/ufshpb.c:1026:31: warning: context imbalance in
> 'ufshpb_run_active_subregion_list' - different lock contexts for basic block

Martin - Thanks.

Daejun - please run Sparse as well, not just checkpatch to eliminate those warnings.

Thanks,
Avri