linux-kernel - Re: [PATCH] iio: frequency: ad9523: convert rest of driver to device managed functions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CA+U=DsopNdqrEdnjY2r3mfd1bqeTR81PdH1mbtXSGHzUEpbarQ@mail.gmail.com>
Date:   Wed, 22 Jul 2020 10:02:05 +0300
From:   Alexandru Ardelean <ardeleanalex@...il.com>
To:     Andy Shevchenko <andy.shevchenko@...il.com>
Cc:     Alexandru Ardelean <alexandru.ardelean@...log.com>,
        linux-iio <linux-iio@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Jonathan Cameron <jic23@...nel.org>
Subject: Re: [PATCH] iio: frequency: ad9523: convert rest of driver to device
 managed functions

On Tue, Jul 21, 2020 at 10:34 PM Andy Shevchenko
<andy.shevchenko@...il.com> wrote:
>
> On Tue, Jul 21, 2020 at 2:27 PM Alexandru Ardelean
> <alexandru.ardelean@...log.com> wrote:
> >
> > The driver pretty much uses device managed functions. The only left-over is
> > the iio_device_register() function, which also requires an action-or-reset
> > hook to disable the regulator on the remove and error path.
> >
> > Signed-off-by: Alexandru Ardelean <alexandru.ardelean@...log.com>
>
> ...
>
>
> > +       ret = devm_iio_device_register(&spi->dev, indio_dev);
> > +       if (ret == 0)
>
> > +               dev_info(&spi->dev, "probed %s\n", indio_dev->name);
> >
> >         return ret;
>
> Please, drop this useless spam (I agree here with Greg KH) and use simply
> return devm_iio_...(...);

I was also a bit undecided whether to keep it.
Will drop.

>
> --
> With Best Regards,
> Andy Shevchenko