linux-kernel - Re: [PATCH] scripts/decode_stacktrace: strip all base path prefixes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <7cbb943e-4145-0ef8-1b86-fcba37dfd41e@suse.cz>
Date:   Wed, 22 Jul 2020 09:12:29 +0200
From:   Jiri Slaby <jslaby@...e.cz>
To:     Andrew Morton <akpm@...ux-foundation.org>
Cc:     linux-kernel@...r.kernel.org, Sasha Levin <sashal@...nel.org>,
        Pi-Hsun Shih <pihsun@...omium.org>,
        Shik Chen <shik@...omium.org>,
        Stephen Boyd <swboyd@...omium.org>,
        Nicolas Boichat <drinkcat@...omium.org>
Subject: Re: [PATCH] scripts/decode_stacktrace: strip all base path prefixes

On 21. 07. 20, 1:05, Andrew Morton wrote:
> On Mon, 20 Jul 2020 09:44:29 +0200 Jiri Slaby <jslaby@...e.cz> wrote:
> 
>> When addr2line returns more than one location, decode_stacktrace does
>> not currently remove base path from the paths. So the result might look
>> like (line wrapped here):
>>  ptrace_stop (include/linux/freezer.h:57
>>  /home/abuild/rpmbuild/BUILD/kernel-default-5.8.rc5/linux-5.8-rc5/linux-obj/../include/linux/freezer.h:67
>>  /home/abuild/rpmbuild/BUILD/kernel-default-5.8.rc5/linux-5.8-rc5/linux-obj/../include/linux/freezer.h:128
>>  /home/abuild/rpmbuild/BUILD/kernel-default-5.8.rc5/linux-5.8-rc5/linux-obj/../include/linux/freezer.h:173
>>  /home/abuild/rpmbuild/BUILD/kernel-default-5.8.rc5/linux-5.8-rc5/linux-obj/../kernel/signal.c:2217)
>>
>> Make sure all the lines are processed, so the result now looks like
>> (line wrapped here again):
>>  ptrace_stop (include/linux/freezer.h:57 include/linux/freezer.h:67
>>  include/linux/freezer.h:128 include/linux/freezer.h:173
>>  kernel/signal.c:2217)
> 
> hm, I just merged
> http://lkml.kernel.org/r/20200720082709.252805-1-pihsun@chromium.org. 
> Which is preferable?

Nobody cares, apparently. And I don't mind either of them. You can add:

Reviewed-by: Jiri Slaby <jirislaby@...nel.org>

to the other one if you want. FTR it is this commit in -next-20200721:

commit a1bc7c359e6044391cfc759ae8a2adf0bc5cd731
Author: Pi-Hsun Shih <pihsun@...omium.org>
Date:   Tue Jul 21 12:57:33 2020 +1000

    scripts/decode_stacktrace: strip basepath from all paths


thanks,
-- 
js
suse labs