linux-kernel - Re: [patch V4 02/15] entry: Provide generic syscall entry functionality

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87o8o82eas.fsf@nanos.tec.linutronix.de>
Date:   Wed, 22 Jul 2020 09:34:51 +0200
From:   Thomas Gleixner <tglx@...utronix.de>
To:     Kees Cook <keescook@...omium.org>
Cc:     LKML <linux-kernel@...r.kernel.org>, x86@...nel.org,
        linux-arch@...r.kernel.org, Will Deacon <will@...nel.org>,
        Arnd Bergmann <arnd@...db.de>,
        Mark Rutland <mark.rutland@....com>,
        Keno Fischer <keno@...iacomputing.com>,
        Paolo Bonzini <pbonzini@...hat.com>, kvm@...r.kernel.org,
        Gabriel Krisman Bertazi <krisman@...labora.com>
Subject: Re: [patch V4 02/15] entry: Provide generic syscall entry functionality

Kees Cook <keescook@...omium.org> writes:
> On Tue, Jul 21, 2020 at 12:57:08PM +0200, Thomas Gleixner wrote:
>> --- /dev/null
>> +++ b/kernel/entry/Makefile
>> @@ -0,0 +1,3 @@
>> +# SPDX-License-Identifier: GPL-2.0
>> +
>> +obj-$(CONFIG_GENERIC_ENTRY) += common.o
>
> But, my point is, let's avoid tripping over this again, and retain the
> disabling here:
>
> CFLAGS_common.o += -fno-stack-protector
>
> I can add this again later, but it'd be nice if it was done here to
> avoid gaining back the TIF_WORK stack protector overhead penalty (which
> we're free of in v5.8 for the first time). ;)

Duh, yes. I completely forgot about that.

Thanks for spotting it!

       tglx