linux-kernel - Re: [PATCH] KEYS: remove redundant memsets

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <695450.1595404904@warthog.procyon.org.uk>
Date:   Wed, 22 Jul 2020 09:01:44 +0100
From:   David Howells <dhowells@...hat.com>
To:     trix@...hat.com
Cc:     dhowells@...hat.com, jarkko.sakkinen@...ux.intel.com,
        jmorris@...ei.org, serge@...lyn.com, denkenz@...il.com,
        marcel@...tmann.org, keyrings@...r.kernel.org,
        linux-security-module@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] KEYS: remove redundant memsets

trix@...hat.com wrote:

> -	if (copy_from_user(&uparams, _params, sizeof(uparams)) != 0)
> -		return -EFAULT;
> -
>  	ret = keyctl_pkey_params_get(uparams.key_id, _info, params);

Erm...  uparams is used on the very next statement after the copy_from_user().

David