linux-kernel - Re: [PATCH] spi-nor: Remove unused spi-nor.o rule

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CACPK8XcxkAiAD2UWVmVH-6TxNKyrv9z3cOB9ptxVw+kiQgCuqA@mail.gmail.com>
Date:   Wed, 22 Jul 2020 09:31:42 +0000
From:   Joel Stanley <joel@....id.au>
To:     Tudor Ambarus <tudor.ambarus@...rochip.com>,
        Boris Brezillon <bbrezillon@...nel.org>
Cc:     Cédric Le Goater <clg@...d.org>,
        linux-mtd <linux-mtd@...ts.infradead.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] spi-nor: Remove unused spi-nor.o rule

On Wed, 22 Jul 2020 at 09:00, Joel Stanley <joel@....id.au> wrote:
>
> In "mtd: spi-nor: Prepare core / manufacturer code split" the file was
> refactored into seperate files, so the rule is no longer required.

Please ignore this patch. I misunderstood how spi-nor-objs worked, and
didn't properly test the patch.

I am still a bit confused as to how spi-nor.o gets linked in, as
there's no spi-nor.o on my filesystem. Can someone explain how it
works?

> Fixes: a0900d0195d2 ("mtd: spi-nor: Prepare core / manufacturer code split")
> Reported-by: Cédric Le Goater <clg@...d.org>
> Signed-off-by: Joel Stanley <joel@....id.au>
> ---
>  drivers/mtd/spi-nor/Makefile | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/drivers/mtd/spi-nor/Makefile b/drivers/mtd/spi-nor/Makefile
> index 653923896205..2ede5ef79b01 100644
> --- a/drivers/mtd/spi-nor/Makefile
> +++ b/drivers/mtd/spi-nor/Makefile
> @@ -17,6 +17,5 @@ spi-nor-objs                  += sst.o
>  spi-nor-objs                   += winbond.o
>  spi-nor-objs                   += xilinx.o
>  spi-nor-objs                   += xmc.o
> -obj-$(CONFIG_MTD_SPI_NOR)      += spi-nor.o
>
>  obj-$(CONFIG_MTD_SPI_NOR)      += controllers/
> --
> 2.27.0
>