linux-kernel - Re: [PATCH 4.19 094/133] USB: serial: iuu

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200722110528.GK3634@localhost>
Date:   Wed, 22 Jul 2020 13:05:28 +0200
From:   Johan Hovold <johan@...nel.org>
To:     Pavel Machek <pavel@...x.de>
Cc:     Johan Hovold <johan@...nel.org>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        linux-kernel@...r.kernel.org, stable@...r.kernel.org
Subject: Re: [PATCH 4.19 094/133] USB: serial: iuu_phoenix: fix memory
 corruption

On Wed, Jul 22, 2020 at 12:52:47PM +0200, Pavel Machek wrote:

> > > Ok, so... goto and label is unneccessary, memcpy will do the right
> > > thing with count == 0.
> > 
> > That's generally too subtle. Better to clearly mark the error/exception
> > path.
> 
> We usually avoid subtle code by introducing comments, not by
> introducing extra (and confusing) code that can not be optimized out.

It's not confusing at all. Just drop it.

Johan

Download attachment "signature.asc" of type "application/pgp-signature" (229 bytes)