linux-kernel - Re: [PATCH v31 03/12] leds: lp50xx: Add the LP50XX family of the RGB LED driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c4e2b2db-483f-27ef-9869-3b0c56d0d8ba@ti.com>
Date:   Wed, 22 Jul 2020 07:26:37 -0500
From:   Dan Murphy <dmurphy@...com>
To:     Pavel Machek <pavel@....cz>
CC:     <jacek.anaszewski@...il.com>, <robh@...nel.org>,
        <marek.behun@....cz>, <devicetree@...r.kernel.org>,
        <linux-leds@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        <linux-arm-kernel@...ts.infradead.org>
Subject: Re: [PATCH v31 03/12] leds: lp50xx: Add the LP50XX family of the RGB
 LED driver

Pavel

On 7/22/20 2:10 AM, Pavel Machek wrote:
> Hi!
>
>>>> +			ret = fwnode_property_read_u32_array(child,
>>>> +							     "reg",
>>>> +							     led_banks,
>>>> +							     ret);
>>> Move this to subfunction to reduce the indentation? (Or, just refactor
>>> it somehow).
>> Actually I can just put it all on the same line since the 80 character
>> requirement is relaxed.
> No.
>
> You have too long and too complex function, with too many blocks
> inside each other. Please fix it.

I will refactor

Dan