linux-kernel - Re: [PATCH v13 1/2] ACPI / APEI: Add a notifier chain for unknown (vendor) CPER records

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200722125038.GZ3703480@smile.fi.intel.com>
Date:   Wed, 22 Jul 2020 15:50:38 +0300
From:   Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To:     Shiju Jose <shiju.jose@...wei.com>
Cc:     "linux-acpi@...r.kernel.org" <linux-acpi@...r.kernel.org>,
        "linux-pci@...r.kernel.org" <linux-pci@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "rjw@...ysocki.net" <rjw@...ysocki.net>,
        "helgaas@...nel.org" <helgaas@...nel.org>,
        "bp@...en8.de" <bp@...en8.de>,
        "james.morse@....com" <james.morse@....com>,
        "lenb@...nel.org" <lenb@...nel.org>,
        "tony.luck@...el.com" <tony.luck@...el.com>,
        "dan.carpenter@...cle.com" <dan.carpenter@...cle.com>,
        "zhangliguang@...ux.alibaba.com" <zhangliguang@...ux.alibaba.com>,
        "Wangkefeng (OS Kernel Lab)" <wangkefeng.wang@...wei.com>,
        "jroedel@...e.de" <jroedel@...e.de>,
        Linuxarm <linuxarm@...wei.com>,
        yangyicong <yangyicong@...wei.com>,
        Jonathan Cameron <jonathan.cameron@...wei.com>,
        tanxiaofei <tanxiaofei@...wei.com>
Subject: Re: [PATCH v13 1/2] ACPI / APEI: Add a notifier chain for unknown
 (vendor) CPER records

On Wed, Jul 22, 2020 at 12:34:23PM +0000, Shiju Jose wrote:
> >-----Original Message-----
> >From: Andy Shevchenko [mailto:andriy.shevchenko@...ux.intel.com]
> >Sent: 22 July 2020 12:02
> >To: Shiju Jose <shiju.jose@...wei.com>
> >Cc: linux-acpi@...r.kernel.org; linux-pci@...r.kernel.org; linux-
> >kernel@...r.kernel.org; rjw@...ysocki.net; helgaas@...nel.org;
> >bp@...en8.de; james.morse@....com; lenb@...nel.org;
> >tony.luck@...el.com; dan.carpenter@...cle.com;
> >zhangliguang@...ux.alibaba.com; Wangkefeng (OS Kernel Lab)
> ><wangkefeng.wang@...wei.com>; jroedel@...e.de; Linuxarm
> ><linuxarm@...wei.com>; yangyicong <yangyicong@...wei.com>; Jonathan
> >Cameron <jonathan.cameron@...wei.com>; tanxiaofei
> ><tanxiaofei@...wei.com>
> >Subject: Re: [PATCH v13 1/2] ACPI / APEI: Add a notifier chain for unknown
> >(vendor) CPER records
> >
> >On Wed, Jul 22, 2020 at 11:39:51AM +0100, Shiju Jose wrote:
> >> CPER records describing a firmware-first error are identified by GUID.
> >> The ghes driver currently logs, but ignores any unknown CPER records.
> >> This prevents describing errors that can't be represented by a
> >> standard entry, that would otherwise allow a driver to recover from an
> >error.
> >> The UEFI spec calls these 'Non-standard Section Body' (N.2.3 of
> >> version 2.8).
> >>
> >> Add a notifier chain for these non-standard/vendor-records. Callers
> >> must identify their type of records by GUID.
> >>
> >> Record data is copied to memory from the ghes_estatus_pool to allow us
> >> to keep it until after the notifier has run.
> >>
> >> Co-developed-by: James Morse <james.morse@....com>
> >
> >Co-developed-by: is going _in conjunction with_ SoB tag which is missing
> >here.
> This tag was added as per instruction from Rafael.
> I was told that I cannot add SoB tag for others unless specifically given.
> Probably I will leave it with Rafael/James to help on this SoB tag
> as Rafael was ok to merge this patch.

I think it's a misunderstanding somewhere. According to [1]:
"Since Co-developed-by: denotes authorship, every Co-developed-by: must be
immediately followed by a Signed-off-by: of the associated co-author."

It means either both or none.

[1]: https://www.kernel.org/doc/html/latest/process/submitting-patches.html

-- 
With Best Regards,
Andy Shevchenko