linux-kernel - Re: [PATCH][next] i2c: designware: Use fallthrough pseudo-keyword

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 22 Jul 2020 09:37:13 -0500
From:   "Gustavo A. R. Silva" <gustavoars@...nel.org>
To:     Andy Shevchenko <andy.shevchenko@...il.com>
Cc:     Jarkko Nikula <jarkko.nikula@...ux.intel.com>,
        Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
        Mika Westerberg <mika.westerberg@...ux.intel.com>,
        linux-i2c <linux-i2c@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        "Gustavo A. R. Silva" <gustavo@...eddedor.com>
Subject: Re: [PATCH][next] i2c: designware: Use fallthrough pseudo-keyword

On Wed, Jul 22, 2020 at 11:52:56AM +0300, Andy Shevchenko wrote:
> On Wed, Jul 22, 2020 at 2:48 AM Gustavo A. R. Silva
> <gustavoars@...nel.org> wrote:
> >
> > Replace the existing /* fall through */ comments and its variants with
> > the new pseudo-keyword macro fallthrough[1].
> 
> Reviewed-by: Andy Shevchenko <andy.shevchenko@...il.com>
> 
> 
> > [1] https://www.kernel.org/doc/html/v5.7/process/deprecated.html?highlight=fallthrough#implicit-switch-case-fall-through
> 
> Perhaps you may do it as Link: tag?
> 

mmh... that's a good suggestion; thanks, Andy.

--
Gustavo

> > Signed-off-by: Gustavo A. R. Silva <gustavoars@...nel.org>
> > ---
> >  drivers/i2c/busses/i2c-designware-pcidrv.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/i2c/busses/i2c-designware-pcidrv.c b/drivers/i2c/busses/i2c-designware-pcidrv.c
> > index 8522134f9ea9..55c83a7a24f3 100644
> > --- a/drivers/i2c/busses/i2c-designware-pcidrv.c
> > +++ b/drivers/i2c/busses/i2c-designware-pcidrv.c
> > @@ -90,7 +90,7 @@ static int mfld_setup(struct pci_dev *pdev, struct dw_pci_controller *c)
> >         switch (pdev->device) {
> >         case 0x0817:
> >                 dev->timings.bus_freq_hz = I2C_MAX_STANDARD_MODE_FREQ;
> > -               /* fall through */
> > +               fallthrough;
> >         case 0x0818:
> >         case 0x0819:
> >                 c->bus_num = pdev->device - 0x817 + 3;
> > --
> > 2.27.0
> >
> 
> 
> -- 
> With Best Regards,
> Andy Shevchenko