linux-kernel - Re: [PATCH v2 0/2] Remove MT6779 UART3 clock support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 22 Jul 2020 17:21:41 +0200
From:   Matthias Brugger <matthias.bgg@...il.com>
To:     Hanks Chen <hanks.chen@...iatek.com>
Cc:     Michael Turquette <mturquette@...libre.com>,
        Stephen Boyd <sboyd@...nel.org>,
        Rob Herring <robh+dt@...nel.org>,
        YueHaibing <yuehaibing@...wei.com>,
        mtk01761 <wendell.lin@...iatek.com>,
        CC Hwang <cc.hwang@...iatek.com>, linux-gpio@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org,
        linux-mediatek@...ts.infradead.org, linux-kernel@...r.kernel.org,
        wsd_upstream@...iatek.com
Subject: Re: [PATCH v2 0/2] Remove MT6779 UART3 clock support



On 22/07/2020 13:16, Hanks Chen wrote:
> On Wed, 2020-07-22 at 10:43 +0200, Matthias Brugger wrote:
>>
>> On 22/07/2020 05:09, Hanks Chen wrote:
>>> remove the redundant clk interface of uart.
>>> CLK_INFRA_UART3 is a dummy clk interface,
>>> it has no effect on the operation of the read/write instruction.
>>>
>>> Change since v2:
>>> Commit "dt-bindings: clock: remove UART3 clock support"
>>
>> Sorry just another comment. I think we can make this one patch deleting everything.
>>
> Sorry, I don't understand the comment. Do I need to merge them into one
> big patch?
> Btw, if I use one patch, I would get check patch fail.
> ---
> [2020-07-22 19:12:49,046 ERROR] Run check patch results:
> WARNING:DT_SPLIT_BINDING_PATCH: DT binding docs and includes should be a
> separate patch. See:
> Documentation/devicetree/bindings/submitting-patches.rst
> ---

Hm, I think that's a debatable error message from checkpatch, but let's leave it 
as it is.

Regards,
Matthias


> 
> Hanks
> 
>>> -- remove Fixes tag
>>> Commit "clk: mediatek: remove UART3 clock support"
>>> -- remove Fixes tag
>>>
>>> Hanks Chen (2):
>>>     dt-bindings: clock: remove UART3 clock support
>>>     clk: mediatek: remove UART3 clock support
>>>
>>>    drivers/clk/mediatek/clk-mt6779.c      | 2 --
>>>    include/dt-bindings/clock/mt6779-clk.h | 1 -
>>>    2 files changed, 3 deletions(-)
>>>
>