lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 22 Jul 2020 10:31:54 -0500 From: Pierre-Louis Bossart <pierre-louis.bossart@...ux.intel.com> To: Srinivas Kandagatla <srinivas.kandagatla@...aro.org>, broonie@...nel.org Cc: alsa-devel@...a-project.org, ckeepax@...nsource.cirrus.com, lgirdwood@...il.com, linux-kernel@...r.kernel.org, tiwai@...e.com, vkoul@...nel.org Subject: Re: [PATCH v2 8/9] ASoC: qdsp6-dai: add gapless support >>> @@ -917,6 +1018,14 @@ static int q6asm_dai_compr_trigger(struct >>> snd_soc_component *component, >>> ret = q6asm_cmd_nowait(prtd->audio_client, prtd->stream_id, >>> CMD_PAUSE); >>> break; >>> + case SND_COMPR_TRIGGER_NEXT_TRACK: >>> + prtd->next_track = true; >>> + prtd->next_track_stream_id = (prtd->stream_id == 1 ? 2 : 1); >> >> it's rather odd, the initialization above uses next_track_stream_id = 0? > > Vaild stream ids start from 1, So we are toggling this between 1 and 2. > So when we set next_track_stream_id to 0, that means we have opened the > new next stream id and is set to prtd->stream_id. This logic is to > ensure that we are not going to open next stream id twice! ok, adding a comment would be good to show this was intentional and not a mistake.
Powered by blists - more mailing lists