linux-kernel - Re: [PATCH v4 08/16] thermal: sun8i: add TEMP_CALIB_MASK for calibration data in sun50i_h6_ths

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200723165625.zo5d4sv27y3dtcbb@gilmour.lan>
Date:   Thu, 23 Jul 2020 18:56:25 +0200
From:   Maxime Ripard <maxime@...no.tech>
To:     Daniel Lezcano <daniel.lezcano@...aro.org>
Cc:     Frank Lee <tiny.windzz@...il.com>,
        Frank Lee <frank@...winnertech.com>,
        Vasily Khoruzhick <anarsoul@...il.com>,
        Zhang Rui <rui.zhang@...el.com>,
        Amit Kucheria <amit.kucheria@...durent.com>,
        Chen-Yu Tsai <wens@...e.org>,
        Linux PM <linux-pm@...r.kernel.org>,
        Linux ARM <linux-arm-kernel@...ts.infradead.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        黄烁生 <huangshuosheng@...winnertech.com>,
        liyong@...winnertech.com
Subject: Re: [PATCH v4 08/16] thermal: sun8i: add TEMP_CALIB_MASK for
 calibration data in sun50i_h6_ths_calibrate

On Mon, Jul 20, 2020 at 12:38:10PM +0200, Daniel Lezcano wrote:
> On 20/07/2020 11:27, Frank Lee wrote:
> > HI,
> > On Fri, Jul 17, 2020 at 3:56 PM Daniel Lezcano
> > <daniel.lezcano@...aro.org> wrote:
> >>
> >> On 17/07/2020 09:35, Frank Lee wrote:
> >>> On Fri, Jul 17, 2020 at 12:26 PM Daniel Lezcano
> >>> <daniel.lezcano@...aro.org> wrote:
> >>>>
> >>>> On 14/07/2020 09:13, Frank Lee wrote:
> >>>>> From: Yangtao Li <frank@...winnertech.com>
> >>>>>
> >>>>> For sun50i_h6_ths_calibrate(), the data read from nvmem needs a round of
> >>>>> calculation. On the other hand, the newer SOC may store other data in
> >>>>> the space other than 12bit sensor data. Add mask operation to read data
> >>>>> to avoid conversion error.
> >>>>>
> >>>>> Signed-off-by: Yangtao Li <frank@...winnertech.com>
> >>>>> Reviewed-by: Yangtao Li <tiny.windzz@...il.com>
> >>>>
> >>>> Can you clarify these SoB ?
> >>>
> >>> Previously I used 'Signed-off-by: Yangtao Li <tiny.windzz@...il.com>',
> >>> maybe this should be removed directly?
> >>>
> >>>>
> >>>> Frank Lee==Yangtao Li==frank@...winnertech.com==tiny.windzz@...il.com ?
> >>>>
> >>>
> >>> Yeah.
> >>
> >> You are not supposed to add reviewed-by yourself. Please remove it.
> > 
> > Should I resend the entire series or just the thermal patch?
> > What about those that have been applied.
> 
> I can not speak on behalf of other maintainers.
> 
> The simplest would be to ask them directly.
> 
> If you want to go forward with the thermal changes, you can send them
> separately but Maxim's Ack will be needed anyway.

Given that I had a few other comments on the other patches, I guess you
can resend the whole series, it will be simpler to track down.

Maxime