linux-kernel - Re: [PATCH] ceph: remove redundant initialization of variable mds

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <853430a6bb4216a5e4a0d734a18b8401b89e7f4b.camel@kernel.org>
Date:   Thu, 23 Jul 2020 13:24:11 -0400
From:   Jeff Layton <jlayton@...nel.org>
To:     Colin King <colin.king@...onical.com>,
        Ilya Dryomov <idryomov@...il.com>, ceph-devel@...r.kernel.org
Cc:     kernel-janitors@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ceph: remove redundant initialization of variable mds

On Thu, 2020-07-23 at 16:22 +0100, Colin King wrote:
> From: Colin Ian King <colin.king@...onical.com>
> 
> The variable mds is being initialized with a value that is never read
> and it is being updated later with a new value.  The initialization is
> redundant and can be removed.
> 
> Addresses-Coverity: ("Unused value")
> Signed-off-by: Colin Ian King <colin.king@...onical.com>
> ---
>  fs/ceph/debugfs.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/fs/ceph/debugfs.c b/fs/ceph/debugfs.c
> index 070ed8481340..48f5afb56c91 100644
> --- a/fs/ceph/debugfs.c
> +++ b/fs/ceph/debugfs.c
> @@ -272,7 +272,7 @@ static int mds_sessions_show(struct seq_file *s, void *ptr)
>  	struct ceph_mds_client *mdsc = fsc->mdsc;
>  	struct ceph_auth_client *ac = fsc->client->monc.auth;
>  	struct ceph_options *opt = fsc->client->options;
> -	int mds = -1;
> +	int mds;
>  
>  	mutex_lock(&mdsc->mutex);
>  

Thanks, merged into testing branch.
-- 
Jeff Layton <jlayton@...nel.org>