linux-kernel - Re: [PATCH v2] x86/configs: Remove CONFIG_CRYPTO_AES_586 from i386

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 23 Jul 2020 19:51:13 +0200
From:   Sedat Dilek <sedat.dilek@...il.com>
To:     Randy Dunlap <rdunlap@...radead.org>
Cc:     Thomas Gleixner <tglx@...utronix.de>,
        Ingo Molnar <mingo@...hat.com>, Borislav Petkov <bp@...en8.de>,
        x86@...nel.org, "H. Peter Anvin" <hpa@...or.com>,
        Diego Elio Pettenò <flameeyes@...meeyes.com>,
        "Maciej W. Rozycki" <macro@...ux-mips.org>,
        "Martin K. Petersen" <martin.petersen@...cle.com>,
        Masahiro Yamada <masahiroy@...nel.org>,
        linux-kernel@...r.kernel.org,
        Ard Biesheuvel <ard.biesheuvel@...aro.org>,
        Herbert Xu <herbert@...dor.apana.org.au>
Subject: Re: [PATCH v2] x86/configs: Remove CONFIG_CRYPTO_AES_586 from i386_defconfig

On Thu, Jul 23, 2020 at 7:29 PM Randy Dunlap <rdunlap@...radead.org> wrote:
>
> On 7/23/20 10:11 AM, Sedat Dilek wrote:
> > Initially CONFIG_CRYPTO_AES_586=y was added to i386_defconfig file
> > with commit c1b362e3b4d3 ("x86: update defconfigs").
> >
> > The code and Kconfig for CONFIG_CRYPTO_AES_586 was removed in:
> >
> > commit 1d2c3279311e4f03fcf164e1366f2fda9f4bfccf
> > ("crypto: x86/aes - drop scalar assembler implementations")
> >
> > Remove the Kconfig relict from i386_defconfig file.
>
>                      relic
>

leftover :-)

https://dict.leo.org/englisch-deutsch/Relikt

> >
> > Cc: Ard Biesheuvel <ard.biesheuvel@...aro.org>
> > Cc: Herbert Xu <herbert@...dor.apana.org.au>
> > Signed-off-by: Sedat Dilek <sedat.dilek@...il.com>
>
> Acked-by: Randy Dunlap <rdunlap@...radead.org>
>

Thanks for the review.

- Sedat -

> Thanks.
>
> > ---
> > Changes v1 -> v2:
> > - Add CC to Ard and Herbert (see commit 1d2c3279311e)
> >
> >  arch/x86/configs/i386_defconfig | 1 -
> >  1 file changed, 1 deletion(-)
> >
> > diff --git a/arch/x86/configs/i386_defconfig b/arch/x86/configs/i386_defconfig
> > index 550904591e94..3a2a89882350 100644
> > --- a/arch/x86/configs/i386_defconfig
> > +++ b/arch/x86/configs/i386_defconfig
> > @@ -290,7 +290,6 @@ CONFIG_SECURITY_NETWORK=y
> >  CONFIG_SECURITY_SELINUX=y
> >  CONFIG_SECURITY_SELINUX_BOOTPARAM=y
> >  CONFIG_SECURITY_SELINUX_DISABLE=y
> > -CONFIG_CRYPTO_AES_586=y
> >  # CONFIG_CRYPTO_ANSI_CPRNG is not set
> >  CONFIG_EFI_STUB=y
> >  CONFIG_ACPI_BGRT=y
> >
>
>
> --
> ~Randy