linux-kernel - Re: [Linux-stm32] [PATCH v3 3/3] ARM: dts: stm32: add initial support for stm32mp157-odyssey board

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 23 Jul 2020 20:47:09 +0200
From:   Marcin Słoniewski <marcin.sloniewski@...il.com>
To:     Christophe Kerello <christophe.kerello@...com>
Cc:     linux-arm-kernel@...ts.infradead.org,
        Rob Herring <robh@...nel.org>,
        Stephan Gerhold <stephan@...hold.net>,
        Manivannan Sadhasivam <mani@...nel.org>,
        Heiko Stuebner <heiko.stuebner@...obroma-systems.com>,
        Linus Walleij <linus.walleij@...aro.org>,
        linux-kernel@...r.kernel.org, Lubomir Rintel <lkundrak@...sk>,
        Mark Brown <broonie@...nel.org>, allen <allen.chen@....com.tw>,
        Sam Ravnborg <sam@...nborg.org>,
        linux-stm32@...md-mailman.stormreply.com,
        devicetree@...r.kernel.org
Subject: Re: [Linux-stm32] [PATCH v3 3/3] ARM: dts: stm32: add initial support
 for stm32mp157-odyssey board

Hi Christophe,

> > +     pinctrl-names = "default", "opendrain", "sleep";
> > +     pinctrl-0 = <&sdmmc2_b4_pins_a &sdmmc2_d47_pins_a>;
> > +     pinctrl-1 = <&sdmmc2_b4_od_pins_a &sdmmc2_d47_pins_a>;
> > +     pinctrl-2 = <&sdmmc2_b4_sleep_pins_a &sdmmc2_d47_sleep_pins_a>;
> > +     non-removable;
> > +     no-sd;
> > +     no-sdio;
> > +     st,neg-edge;
> > +     bus-width = <4>;
> > +     vmmc-supply = <&v3v3>;
> > +     vqmmc-supply = <&v3v3>;
> > +     mmc-ddr-3_3v;
> > +     status = "okay";
> > +};
>
> Based on the pins muxed, 8 data lines are configured, but the bus width
> is set to 4. What is the reason of not setting this property to 8?

Yes, it was workaround, because sdmmc2 interface was working only
with width set to 4. It turned out there was one wrong pin used in
sdmmc2_d47_pins_a.
It will be fixed in v4.

Regards,
Marcin Sloniewski