linux-kernel - Re: [PATCH net-next v3 1/2] hinic: add support to handle hw abnormal event

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20200723.120852.1882569285026023193.davem@davemloft.net>
Date:   Thu, 23 Jul 2020 12:08:52 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     luobin9@...wei.com
Cc:     linux-kernel@...r.kernel.org, netdev@...r.kernel.org,
        luoxianjun@...wei.com, yin.yinshi@...wei.com,
        cloud.wangxiaoyun@...wei.com, chiqijun@...wei.com
Subject: Re: [PATCH net-next v3 1/2] hinic: add support to handle hw
 abnormal event

From: Luo bin <luobin9@...wei.com>
Date: Thu, 23 Jul 2020 22:40:37 +0800

> +static int hinic_fw_reporter_dump(struct devlink_health_reporter *reporter,
> +				  struct devlink_fmsg *fmsg, void *priv_ctx,
> +				  struct netlink_ext_ack *extack)
> +{
> +	struct hinic_mgmt_watchdog_info *watchdog_info;
> +	int err;
> +
> +	if (priv_ctx) {
> +		watchdog_info = priv_ctx;
> +		err = mgmt_watchdog_report_show(fmsg, watchdog_info);
> +		if (err)
> +			return err;
> +	}
> +
> +	return 0;
> +}

This 'watchdog_info' variable is completely unnecessary, just pass
'priv_ctx' as-is into mgmt_watchdog_report_show().