linux-kernel - Re: [PATCH v10 1/2] dt-bindings: iio: Add bindings for sx9310 sensor

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <159553257307.3847286.4297914412173341085@swboyd.mtv.corp.google.com>
Date:   Thu, 23 Jul 2020 12:29:33 -0700
From:   Stephen Boyd <swboyd@...omium.org>
To:     Daniel Campello <campello@...omium.org>,
        LKML <devicetree@...r.kernel.org>,
        LKML <linux-kernel@...r.kernel.org>
Cc:     Jonathan Cameron <jic23@...nel.org>,
        Daniel Campello <campello@...omium.org>,
        Rob Herring <robh@...nel.org>,
        Hartmut Knaack <knaack.h@....de>,
        Lars-Peter Clausen <lars@...afoo.de>,
        Mark Rutland <mark.rutland@....com>,
        Peter Meerwald-Stadler <pmeerw@...erw.net>,
        Rob Herring <robh+dt@...nel.org>, linux-iio@...r.kernel.org
Subject: Re: [PATCH v10 1/2] dt-bindings: iio: Add bindings for sx9310 sensor

Quoting Daniel Campello (2020-04-14 13:36:07)
> Adds device tree bandings for sx9310 sensor.
> 
> Signed-off-by: Daniel Campello <campello@...omium.org>
> Reviewed-by: Rob Herring <robh@...nel.org>
> ---

I don't see this picked up anywhere in linux-next. Can we squash in this
change? Typically the voltage regulator names match the data sheet, and
in this case the datasheet names them vdd and svdd. Also, they're not
strictly necessary to be in the binding if they're always on supplies so
we can remove them from the required section and DT files can omit them
if they don't care to actively power manage them.

---8<---
diff --git a/Documentation/devicetree/bindings/iio/proximity/semtech,sx9310.yaml b/Documentation/devicetree/bindings/iio/proximity/semtech,sx9310.yaml
index b52ffdac678b..ba734ee868c7 100644
--- a/Documentation/devicetree/bindings/iio/proximity/semtech,sx9310.yaml
+++ b/Documentation/devicetree/bindings/iio/proximity/semtech,sx9310.yaml
@@ -31,12 +31,15 @@ properties:
       available or that a close/far proximity event has happened.
     maxItems: 1
 
-  power-supply: true
+  vdd-supply:
+    description: Main power supply
+
+  svdd-supply:
+    description: Host interface power supply
 
 required:
   - compatible
   - reg
-  - power-supply
 
 additionalProperties: false
 
@@ -51,6 +54,7 @@ examples:
         reg = <0x28>;
         interrupt-parent = <&pio>;
         interrupts = <5 IRQ_TYPE_LEVEL_LOW 5>;
-        power-supply = <...>;
+        vdd-supply = <&pp3300_a>;
+        svdd-supply = <&pp1800_prox>;
       };
     };