linux-kernel - Re: [PATCH] media: camss: fix memory leaks on error handling paths in probe

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <64581990-1f68-131d-2e38-8d3e0b9cbd2a@web.de>
Date:   Thu, 23 Jul 2020 21:51:23 +0200
From:   Markus Elfring <Markus.Elfring@....de>
To:     Evgeny Novikov <novikov@...ras.ru>,
        Anton Vasilyev <vasilyev@...ras.ru>,
        ldv-project@...uxtesting.org, linux-arm-msm@...r.kernel.org,
        linux-media@...r.kernel.org
Cc:     kernel-janitors@...r.kernel.org, linux-kernel@...r.kernel.org,
        Andy Gross <agross@...nel.org>,
        Bjorn Andersson <bjorn.andersson@...aro.org>,
        Mauro Carvalho Chehab <mchehab@...nel.org>,
        Todor Tomov <todor.too@...il.com>
Subject: Re: [PATCH] media: camss: fix memory leaks on error handling paths in
 probe

> camss_probe() does not free camss on error handling paths. The patch
> introduces an additional error label for this purpose.

* I suggest to use an imperative wording for the change description.

* Would you like to use also a jump target like the following
  at the end of this function implementation?

+e_nomem:
+	ret = -ENOMEM;
+	goto err_free;


* Will the tag “Fixes” become helpful for the commit message?


>                                                        Besides, it
> removes call of v4l2_async_notifier_cleanup() from
> camss_of_parse_ports() since its caller, camss_probe(), cleans up all
> its resources itself.

I propose to offer such a change by a separate update step.
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?id=d15be546031cf65a0fc34879beca02fd90fe7ac7#n138


Regards,
Markus