linux-kernel - Re: [PATCH] PCI/P2PDMA: Add AMD Zen 2 root complex to the list of allowed bridges

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200723195742.GA1447143@bjorn-Precision-5520>
Date:   Thu, 23 Jul 2020 14:57:42 -0500
From:   Bjorn Helgaas <helgaas@...nel.org>
To:     Alex Deucher <alexdeucher@...il.com>
Cc:     Logan Gunthorpe <logang@...tatee.com>,
        LKML <linux-kernel@...r.kernel.org>,
        Linux PCI <linux-pci@...r.kernel.org>,
        Bjorn Helgaas <bhelgaas@...gle.com>,
        Christian König <christian.koenig@....com>,
        Huang Rui <ray.huang@....com>,
        Andrew Maier <andrew.maier@...eticom.com>,
        Armen Baloyan <abaloyan@...aio.com>,
        "H. Peter Anvin" <hpa@...or.com>
Subject: Re: [PATCH] PCI/P2PDMA: Add AMD Zen 2 root complex to the list of
 allowed bridges

[+cc Andrew, Armen, hpa]

On Thu, Jul 23, 2020 at 02:01:17PM -0400, Alex Deucher wrote:
> On Thu, Jul 23, 2020 at 1:43 PM Logan Gunthorpe <logang@...tatee.com> wrote:
> >
> > The AMD Zen 2 root complex (Starship/Matisse) was tested for P2PDMA
> > transactions between root ports and found to work. Therefore add it
> > to the list.
> >
> > Signed-off-by: Logan Gunthorpe <logang@...tatee.com>
> > Cc: Bjorn Helgaas <bhelgaas@...gle.com>
> > Cc: Christian König <christian.koenig@....com>
> > Cc: Huang Rui <ray.huang@....com>
> > Cc: Alex Deucher <alexdeucher@...il.com>
> 
> Starting with Zen, all AMD platforms support P2P for reads and writes.

What's the plan for getting out of the cycle of "update this list for
every new chip"?  Any new _DSMs planned, for instance?

A continuous trickle of updates like this is not really appealing.  So
far we have:

  7d5b10fcb81e ("PCI/P2PDMA: Add AMD Zen Raven and Renoir Root Ports to whitelist")
  7b94b53db34f ("PCI/P2PDMA: Add Intel Sky Lake-E Root Ports B, C, D to the whitelist")
  bc123a515cb7 ("PCI/P2PDMA: Add Intel SkyLake-E to the whitelist")
  494d63b0d5d0 ("PCI/P2PDMA: Whitelist some Intel host bridges")
  0f97da831026 ("PCI/P2PDMA: Allow P2P DMA between any devices under AMD ZEN Root Complex")

And that's just from the last year, not including this patch.

> > ---
> >  drivers/pci/p2pdma.c | 2 ++
> >  1 file changed, 2 insertions(+)
> >
> > diff --git a/drivers/pci/p2pdma.c b/drivers/pci/p2pdma.c
> > index e8e444eeb1cd..3d67a1ee083e 100644
> > --- a/drivers/pci/p2pdma.c
> > +++ b/drivers/pci/p2pdma.c
> > @@ -284,6 +284,8 @@ static const struct pci_p2pdma_whitelist_entry {
> >         {PCI_VENDOR_ID_AMD,     0x1450, 0},
> >         {PCI_VENDOR_ID_AMD,     0x15d0, 0},
> >         {PCI_VENDOR_ID_AMD,     0x1630, 0},
> > +       /* AMD ZEN 2 */
> > +       {PCI_VENDOR_ID_AMD,     0x1480, 0},
> >
> >         /* Intel Xeon E5/Core i7 */
> >         {PCI_VENDOR_ID_INTEL,   0x3c00, REQ_SAME_HOST_BRIDGE},
> >
> > base-commit: ba47d845d715a010f7b51f6f89bae32845e6acb7
> > --
> > 2.20.1
> >