linux-kernel - Re: [PATCH] media: davinci: vpif_capture: fix potential double free

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <b179ad63-b895-39f7-dc18-23636f77e1e4@web.de>
Date:   Thu, 23 Jul 2020 22:15:16 +0200
From:   Markus Elfring <Markus.Elfring@....de>
To:     Evgeny Novikov <novikov@...ras.ru>, ldv-project@...uxtesting.org,
        linux-media@...r.kernel.org
Cc:     linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org,
        Mauro Carvalho Chehab <mchehab@...nel.org>,
        Prabhakar Lad <prabhakar.csengg@...il.com>
Subject: Re: [PATCH] media: davinci: vpif_capture: fix potential double free

> In case of errors vpif_probe_complete() releases memory for vpif_obj.sd
> and unregisters the V4L2 device. But then this is done again by
> vpif_probe() itself. The patch removes the cleaning from
> vpif_probe_complete().

* An imperative wording can be preferred for the change description,
  can't it?

* Would you like to add the tag “Fixes” to the commit message?

Regards,
Markus