linux-kernel - Re: [PATCH v2 2/2] i2c: iproc: add slave pec support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200723202053.GD908@ninjato>
Date:   Thu, 23 Jul 2020 22:20:53 +0200
From:   Wolfram Sang <wsa@...nel.org>
To:     Rayagonda Kokatanur <rayagonda.kokatanur@...adcom.com>
Cc:     linux-i2c@...r.kernel.org, linux-kernel@...r.kernel.org,
        Ray Jui <rjui@...adcom.com>,
        Scott Branden <sbranden@...adcom.com>,
        bcm-kernel-feedback-list@...adcom.com,
        Lori Hikichi <lori.hikichi@...adcom.com>,
        Robert Richter <rrichter@...vell.com>,
        Nishka Dasgupta <nishkadg.linux@...il.com>,
        Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
        linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH v2 2/2] i2c: iproc: add slave pec support


> +	/* Enable partial slave HW PEC support if requested by the client */
> +	iproc_i2c->en_s_pec = !!(slave->flags & I2C_CLIENT_PEC);
> +	if (iproc_i2c->en_s_pec)
> +		dev_info(iproc_i2c->device, "Enable PEC\n");

Where do you set the I2C_CLIENT_PEC flag for the slave? Is your backend
code publicly available?

I may need a second thought here, but I am not sure I2C_CLIENT_PEC is
the right way to enable PEC. Isn't it actually depending on the backend
if PEC is needed? I.e. is the backend an I2C device or an SMBus device?


Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)