[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <20200723205343.GA839415@bogus>
Date: Thu, 23 Jul 2020 14:53:43 -0600
From: Rob Herring <robh@...nel.org>
To: Huihui Wang <huihui.wang@...iatek.com>
Cc: Sean Wang <sean.wang@...iatek.com>, Vinod Koul <vkoul@...nel.org>,
linux-kernel@...r.kernel.org, linux-mediatek@...ts.infradead.org,
devicetree@...r.kernel.org, wsd_upstream@...iatek.com
Subject: Re: [PATCH v1 1/2] dt-bindings: dma: mediatek: mark useless items as
decrepted
On Fri, Jul 17, 2020 at 11:02:03AM +0800, Huihui Wang wrote:
> From: huihui wang <huihui.wang@...iatek.com>
>
> Because we move dma address bits config to mtk-uart-apdma.c,
> it is unnecessary to be configured in device tree.
> Update the document at the same time.
>
> Signed-off-by: huihui wang <huihui.wang@...iatek.com>
> ---
> .../devicetree/bindings/dma/mtk-uart-apdma.txt | 11 +++++------
> 1 file changed, 5 insertions(+), 6 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/dma/mtk-uart-apdma.txt b/Documentation/devicetree/bindings/dma/mtk-uart-apdma.txt
> index 2117db0ce4f2..926c86b21e8c 100644
> --- a/Documentation/devicetree/bindings/dma/mtk-uart-apdma.txt
> +++ b/Documentation/devicetree/bindings/dma/mtk-uart-apdma.txt
> @@ -2,8 +2,9 @@
>
> Required properties:
> - compatible should contain:
> - * "mediatek,mt2712-uart-dma" for MT2712 compatible APDMA
> - * "mediatek,mt6577-uart-dma" for MT6577 and all of the above
> + * "mediatek,mt2712-uart-dma" for MediaTek MT2712
> + * "mediatek,mt6577-uart-dma" for MediaTek MT6577
> + * "mediatek,mt6779-uart-dma" for MediaTek MT6779
This looks like an unrelated change.
>
> - reg: The base address of the APDMA register bank.
>
> @@ -16,13 +17,12 @@ Required properties:
> See ../clocks/clock-bindings.txt for details.
> - clock-names: The APDMA clock for register accesses
>
> -- mediatek,dma-33bits: Present if the DMA requires support
> +- mediatek,dma-33bits: Present if the DMA requires support (deprecated)
>
> Examples:
>
> apdma: dma-controller@...00400 {
> - compatible = "mediatek,mt2712-uart-dma",
> - "mediatek,mt6577-uart-dma";
> + compatible = "mediatek,mt6779-uart-dma";
> reg = <0 0x11000400 0 0x80>,
> <0 0x11000480 0 0x80>,
> <0 0x11000500 0 0x80>,
> @@ -50,6 +50,5 @@ Examples:
> dma-requests = <12>;
> clocks = <&pericfg CLK_PERI_AP_DMA>;
> clock-names = "apdma";
> - mediatek,dma-33bits;
> #dma-cells = <1>;
> };
> --
> 2.18.0
Powered by blists - more mailing lists