linux-kernel - Re: [PATCH v2 2/5] vfio/pci: Add device blocklist

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20200723214029.GA6572@silpixa00400314>
Date:   Thu, 23 Jul 2020 22:40:29 +0100
From:   Giovanni Cabiddu <giovanni.cabiddu@...el.com>
To:     Alex Williamson <alex.williamson@...hat.com>
Cc:     herbert@...dor.apana.org.au, cohuck@...hat.com, nhorman@...hat.com,
        vdronov@...hat.com, bhelgaas@...gle.com, mark.a.chambers@...el.com,
        gordon.mcfadden@...el.com, ahsan.atta@...el.com,
        qat-linux@...el.com, kvm@...r.kernel.org,
        linux-crypto@...r.kernel.org, linux-pci@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 2/5] vfio/pci: Add device blocklist

On Wed, Jul 22, 2020 at 11:02:10PM -0600, Alex Williamson wrote:
> On Tue, 14 Jul 2020 07:36:07 +0100
> Giovanni Cabiddu <giovanni.cabiddu@...el.com> wrote:
> 
> > Add blocklist of devices that by default are not probed by vfio-pci.
> > Devices in this list may be susceptible to untrusted application, even
> > if the IOMMU is enabled. To be accessed via vfio-pci, the user has to
> > explicitly disable the blocklist.
> > 
> > The blocklist can be disabled via the module parameter disable_blocklist.
> > 
> > Signed-off-by: Giovanni Cabiddu <giovanni.cabiddu@...el.com>
> > ---
> >  drivers/vfio/pci/vfio_pci.c | 33 +++++++++++++++++++++++++++++++++
> >  1 file changed, 33 insertions(+)
> 
> Hi Giovanni,
> 
> I'm pretty satisfied with this series, except "blocklist" makes me
> think of block devices, ie. storage, or block chains, or building block
> types of things before I get to "block" as in a barrier.  The other
> alternative listed as a suggestion currently in linux-next is denylist,
> which is the counter to an allowlist.  I've already proposed changing
> some other terminology in vfio.c to use the term "allowed", so
> allow/deny would be my preference versus pass/block.
Thanks Alex for your feedback. A new revision is on the way.

Regards,

-- 
Giovanni