lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 24 Jul 2020 00:58:34 +0200 From: Salvatore Bonaccorso <carnil@...ian.org> To: Shuah Khan <skhan@...uxfoundation.org> Cc: Antonio Borneo <borneo.antonio@...il.com>, Valentina Manea <valentina.manea.m@...il.com>, Shuah Khan <shuah@...nel.org>, Greg Kroah-Hartman <gregkh@...uxfoundation.org>, Hewenliang <hewenliang4@...wei.com>, linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH] usbip: tools: fix build error for multiple definition Hi, On Thu, Jun 18, 2020 at 11:36:39AM -0600, Shuah Khan wrote: > On 6/17/20 6:08 PM, Antonio Borneo wrote: > > With GCC 10, building usbip triggers error for multiple definition > > of 'udev_context', in: > > - libsrc/vhci_driver.c:18 and > > - libsrc/usbip_host_common.c:27. > > > > Declare as extern the definition in libsrc/usbip_host_common.c. > > > > Signed-off-by: Antonio Borneo <borneo.antonio@...il.com> > > --- > > tools/usb/usbip/libsrc/usbip_host_common.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/tools/usb/usbip/libsrc/usbip_host_common.c b/tools/usb/usbip/libsrc/usbip_host_common.c > > index d1d8ba2a4a40..ca78aa368476 100644 > > --- a/tools/usb/usbip/libsrc/usbip_host_common.c > > +++ b/tools/usb/usbip/libsrc/usbip_host_common.c > > @@ -23,7 +23,7 @@ > > #include "list.h" > > #include "sysfs_utils.h" > > -struct udev *udev_context; > > +extern struct udev *udev_context; > > static int32_t read_attr_usbip_status(struct usbip_usb_device *udev) > > { > > > > Looks good to me. > > Acked-by: Shuah Khan <skhan@...uxfoundation.org> As Debian (unstable) has switched to GCC 10 by default, we are biten by this. Patch looks good to me. Tested-by: Salvatore Bonaccorso <carnil@...ian.org> Regards, Salvatore
Powered by blists - more mailing lists