lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 23 Jul 2020 10:17:34 +0530 From: Vinod Koul <vkoul@...nel.org> To: Pierre-Louis Bossart <pierre-louis.bossart@...ux.intel.com> Cc: Srinivas Kandagatla <srinivas.kandagatla@...aro.org>, broonie@...nel.org, alsa-devel@...a-project.org, ckeepax@...nsource.cirrus.com, lgirdwood@...il.com, linux-kernel@...r.kernel.org, tiwai@...e.com Subject: Re: [RFC PATCH v2 2/6] ALSA: compress: add new ioctl for setting codec parameters On 22-07-20, 10:36, Pierre-Louis Bossart wrote: > > > > > * and the stream properties > > > > + * @set_codec_params: Sets the compressed stream codec > > > > parameters, Optional > > > > + * This can be called in during gapless next track codec change > > > > only to set > > > > + * codec params > > > > > > Would it be clearer if this was called set_next_codec_params()? or > > > set_next_track_codec_params()? > > > > > > Having set_params() and set_codec_params() is a bit confusing since > > > the semantic difference is not captured in the callback name. > > > > set_next_track_codec_params seems more sensible as its next track params. > > Will change this in next version! > > maybe set_params() and set_next_track_params() are enough, not sure if the > codec reference helps? params typically refers to whole set of compress parameters which includes buffer information and codec parameters, so codec reference would help. -- ~Vinod
Powered by blists - more mailing lists