linux-kernel - RE: [PATCH devicetree 3/4] powerpc: dts: t1040rdb: put SGMII PHY under &mdio0 label

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <AM6PR04MB39763CA66048BD4F221D0DE4EC760@AM6PR04MB3976.eurprd04.prod.outlook.com>
Date:   Thu, 23 Jul 2020 05:40:48 +0000
From:   "Madalin Bucur (OSS)" <madalin.bucur@....nxp.com>
To:     Vladimir Oltean <olteanv@...il.com>,
        "robh+dt@...nel.org" <robh+dt@...nel.org>,
        "shawnguo@...nel.org" <shawnguo@...nel.org>,
        "mpe@...erman.id.au" <mpe@...erman.id.au>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>
CC:     "benh@...nel.crashing.org" <benh@...nel.crashing.org>,
        "paulus@...ba.org" <paulus@...ba.org>,
        "linuxppc-dev@...ts.ozlabs.org" <linuxppc-dev@...ts.ozlabs.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "Madalin Bucur (OSS)" <madalin.bucur@....nxp.com>,
        Radu-andrei Bulie <radu-andrei.bulie@....com>,
        "fido_max@...ox.ru" <fido_max@...ox.ru>
Subject: RE: [PATCH devicetree 3/4] powerpc: dts: t1040rdb: put SGMII PHY
 under &mdio0 label

> -----Original Message-----
> From: Vladimir Oltean <olteanv@...il.com>
> Sent: Wednesday, July 22, 2020 8:24 PM
> To: robh+dt@...nel.org; shawnguo@...nel.org; mpe@...erman.id.au;
> devicetree@...r.kernel.org
> Cc: benh@...nel.crashing.org; paulus@...ba.org; linuxppc-
> dev@...ts.ozlabs.org; linux-kernel@...r.kernel.org;
> netdev@...r.kernel.org; Madalin Bucur (OSS) <madalin.bucur@....nxp.com>;
> Radu-andrei Bulie <radu-andrei.bulie@....com>; fido_max@...ox.ru
> Subject: [PATCH devicetree 3/4] powerpc: dts: t1040rdb: put SGMII PHY
> under &mdio0 label
> 
> We're going to add 8 more PHYs in a future patch. It is easier to follow
> the hardware description if we don't need to fish for the path of the
> MDIO controllers inside the SoC and just use the labels.
> 

Please align to the existing structure, it may be easier to add something
without paying attention to that but it's better to keep things organized.
This structure is used across all the device trees of the platforms using
DPAA, let's not start diverging now.

> Signed-off-by: Vladimir Oltean <olteanv@...il.com>
> ---
>  arch/powerpc/boot/dts/fsl/t1040rdb.dts | 12 ++++++------
>  1 file changed, 6 insertions(+), 6 deletions(-)
> 
> diff --git a/arch/powerpc/boot/dts/fsl/t1040rdb.dts
> b/arch/powerpc/boot/dts/fsl/t1040rdb.dts
> index 65ff34c49025..40d7126dbe90 100644
> --- a/arch/powerpc/boot/dts/fsl/t1040rdb.dts
> +++ b/arch/powerpc/boot/dts/fsl/t1040rdb.dts
> @@ -59,12 +59,6 @@ ethernet@...00 {
>  				phy-handle = <&phy_sgmii_2>;
>  				phy-connection-type = "sgmii";
>  			};
> -
> -			mdio@...00 {
> -				phy_sgmii_2: ethernet-phy@3 {
> -					reg = <0x03>;
> -				};
> -			};
>  		};
>  	};
> 
> @@ -76,3 +70,9 @@ cpld@3,0 {
>  };
> 
>  #include "t1040si-post.dtsi"
> +
> +&mdio0 {
> +	phy_sgmii_2: ethernet-phy@3 {
> +		reg = <0x3>;
> +	};
> +};
> --
> 2.25.1