linux-kernel - Re: [PATCH v1] clk: Export __clk

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <159546549321.3847286.4678382117195983280@swboyd.mtv.corp.google.com>
Date:   Wed, 22 Jul 2020 17:51:33 -0700
From:   Stephen Boyd <sboyd@...nel.org>
To:     Elaine Zhang <zhangqing@...k-chips.com>,
        Heiko Stuebner <heiko@...ech.de>
Cc:     mturquette@...libre.com, linux-clk@...r.kernel.org,
        linux-rockchip@...ts.infradead.org, linux-kernel@...r.kernel.org,
        xxx@...k-chips.com, xf@...k-chips.com, huangtao@...k-chips.com,
        kever.yang@...k-chips.com
Subject: Re: [PATCH v1] clk: Export __clk_lookup()

Quoting Heiko Stuebner (2020-07-22 11:26:50)
> Hi Elaine,
> 
> Am Mittwoch, 22. Juli 2020, 04:32:30 CEST schrieb Elaine Zhang:
> > Export __clk_lookup() to support user built as module.
> > 
> > ERROR:
> > drivers/clk/rockchip/clk.ko: In function
> > `rockchip_clk_protect_critical':
> > drivers/clk/rockchip/clk.c:741:
> > undefined reference to `__clk_lookup'
> 
> can you elaborate a bit more on why this would be needed?
> 
> Because right now the Rockchip clocks are of course built into
> the main kernel image (especially due to them being needed during early
> boot) and __clk_lookup actually is a pretty deep part of the clock-
> framework itself, as probably also denoted by the "__" in the function
> name.
> 

Can you stop using __clk_lookup()? The plan is to remove it.