linux-kernel - Re: [PATCH] mips: traps, add __init to parity_protection

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <252bf1ae-6c1d-463e-a035-debb119fa83d@cogentembedded.com>
Date:   Thu, 23 Jul 2020 13:00:14 +0300
From:   Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
To:     Jiri Slaby <jslaby@...e.cz>, tsbogend@...ha.franken.de
Cc:     linux-kernel@...r.kernel.org, linux-mips@...r.kernel.org
Subject: Re: [PATCH] mips: traps, add __init to parity_protection_init

Hello!

On 23.07.2020 12:42, Jiri Slaby wrote:

> It references __initdata and is called only from an __init function:
> trap_init. This avoids section mismatches (which I am seeing with gcc
> 10).
> 
> Signed-off-by: Jiri Slaby <jslaby@...e.cz>
> Cc: Thomas Bogendoerfer <tsbogend@...ha.franken.de>
> Cc: linux-mips@...r.kernel.org
> ---
>   arch/mips/kernel/traps.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/mips/kernel/traps.c b/arch/mips/kernel/traps.c
> index f655af68176c..702143ad7b47 100644
> --- a/arch/mips/kernel/traps.c
> +++ b/arch/mips/kernel/traps.c
> @@ -1680,7 +1680,7 @@ __setup("nol2par", nol2parity);
>    * Some MIPS CPUs can enable/disable for cache parity detection, but do
>    * it different ways.
>    */
> -static inline void parity_protection_init(void)
> +static inline __init void parity_protection_init(void)

    *inline* in a .c file? Perhaps gcc-10 has it out-of-line?

[...]

MBR, Sergei