linux-kernel - Re: [PATCH 1/2] USB: phy: fsl-usb: remove sysfs abuse

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <87k0yuo3wm.fsf@kernel.org>
Date:   Thu, 23 Jul 2020 14:40:41 +0300
From:   Felipe Balbi <balbi@...nel.org>
To:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc:     linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Subject: Re: [PATCH 1/2] USB: phy: fsl-usb: remove sysfs abuse

Greg Kroah-Hartman <gregkh@...uxfoundation.org> writes:

> This file has a HUGE debugging sysfs file that spews out a lot of
> information all at once, which violates the one-value-per-file rule for
> sysfs.  If this is really needed, it should go into debugfs, but given
> the age of this driver, I strongly doubt anyone is using it anymore.
>
> So just remove the file entirely, it was never documented, so obviously,
> no one actually needed it :)
>
> Cc: Felipe Balbi <balbi@...nel.org>
> Signed-off-by: Greg Kroah-Hartman <gregkh@...uxfoundation.org>

applied both, thanks Greg.

-- 
balbi

Download attachment "signature.asc" of type "application/pgp-signature" (833 bytes)