lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 23 Jul 2020 09:24:21 +0800 From: Yingjoe Chen <yingjoe.chen@...iatek.com> To: Qii Wang <qii.wang@...iatek.com> CC: <wsa@...-dreams.de>, <qiangming.xia@...iatek.com>, <devicetree@...r.kernel.org>, <srv_heupstream@...iatek.com>, <leilk.liu@...iatek.com>, <linux-kernel@...r.kernel.org>, <robh+dt@...nel.org>, <linux-mediatek@...ts.infradead.org>, <linux-i2c@...r.kernel.org>, <linux-arm-kernel@...ts.infradead.org> Subject: Re: [PATCH 2/4] i2c: mediatek: Support DMA mask range over 33-bits On Wed, 2020-07-22 at 20:31 +0800, Qii Wang wrote: > Replace 'support_33bits with 'dma_max_support' for DMA mask > operation, and replace 'mtk_i2c_set_4g_mode' with 'upper_32_bits'. This doesn't explain why we need this patch. How about: Newer MTK chip support more than 8GB of dram. Replace support_33bits with more general dma_max_support. > > Signed-off-by: Qii Wang <qii.wang@...iatek.com> > --- > drivers/i2c/busses/i2c-mt65xx.c | 37 +++++++++++++++++-------------------- > 1 file changed, 17 insertions(+), 20 deletions(-) > > diff --git a/drivers/i2c/busses/i2c-mt65xx.c b/drivers/i2c/busses/i2c-mt65xx.c > index e6b984a..e475877 100644 > --- a/drivers/i2c/busses/i2c-mt65xx.c > +++ b/drivers/i2c/busses/i2c-mt65xx.c > @@ -209,6 +209,7 @@ struct mtk_i2c_compatible { > unsigned char dma_sync: 1; > unsigned char ltiming_adjust: 1; > unsigned char apdma_sync: 1; > + unsigned char max_dma_support; support_33bits is no longer used. Please remove it. Joe.C
Powered by blists - more mailing lists