linux-kernel - Re: [PATCH] usb: gadget: epautoconf: claim smallest endpoints first

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <87blk6nzkl.fsf@kernel.org>
Date:   Thu, 23 Jul 2020 16:14:18 +0300
From:   Felipe Balbi <balbi@...nel.org>
To:     Ruslan Bilovol <ruslan.bilovol@...il.com>
Cc:     gregkh@...uxfoundation.org, linux-usb@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] usb: gadget: epautoconf: claim smallest endpoints first

Ruslan Bilovol <ruslan.bilovol@...il.com> writes:

> UDC hardware may have endpoints with different maxpacket
> size. Current endpoint matching code takes first matching
> endpoint from the list.
>
> It's always possible that gadget allocates endpoints for
> small transfers (maxpacket size) first, then larger ones.
> That works fine if all matching UDC endpoints have same
> maxpacket size or are big enough to serve that allocation.
>
> However, some UDCs have first endpoints in the list with
> bigger maxpacket size, whereas last endpoints are much
> smaller. In this case endpoint allocation will fail for
> the gadget (which allocates smaller endpoints first) on
> final endpoint allocations.
>
> To make endpoint allocation fair, pick up smallest
> matching endpoints first, leaving bigger ones for
> heavier applications.
>
> Signed-off-by: Ruslan Bilovol <ruslan.bilovol@...il.com>

checking file drivers/usb/gadget/epautoconf.c
Hunk #1 succeeded at 151 with fuzz 1 (offset 85 lines).
Hunk #2 FAILED at 77.
1 out of 2 hunks FAILED
-- 
balbi

Download attachment "signature.asc" of type "application/pgp-signature" (833 bytes)