linux-kernel - RE: [PATCH v10 05/12] dmaengine: dma: imx-sdma: add fw_loaded and is_ram

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <VE1PR04MB6638FFA76076ECCA9CE8F2C289760@VE1PR04MB6638.eurprd04.prod.outlook.com>
Date:   Thu, 23 Jul 2020 14:11:19 +0000
From:   Robin Gong <yibin.gong@....com>
To:     Frieder Schrempf <frieder.schrempf@...tron.de>,
        "mark.rutland@....com" <mark.rutland@....com>,
        "broonie@...nel.org" <broonie@...nel.org>,
        "robh+dt@...nel.org" <robh+dt@...nel.org>,
        "catalin.marinas@....com" <catalin.marinas@....com>,
        "vkoul@...nel.org" <vkoul@...nel.org>,
        "will.deacon@....com" <will.deacon@....com>,
        "shawnguo@...nel.org" <shawnguo@...nel.org>,
        "festevam@...il.com" <festevam@...il.com>,
        "s.hauer@...gutronix.de" <s.hauer@...gutronix.de>,
        "martin.fuzzey@...wbird.group" <martin.fuzzey@...wbird.group>,
        "u.kleine-koenig@...gutronix.de" <u.kleine-koenig@...gutronix.de>,
        "dan.j.williams@...el.com" <dan.j.williams@...el.com>,
        "matthias.schiffer@...tq-group.com" 
        <matthias.schiffer@...tq-group.com>
CC:     "linux-spi@...r.kernel.org" <linux-spi@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        "kernel@...gutronix.de" <kernel@...gutronix.de>,
        "dmaengine@...r.kernel.org" <dmaengine@...r.kernel.org>,
        dl-linux-imx <linux-imx@....com>
Subject: RE: [PATCH v10 05/12] dmaengine: dma: imx-sdma: add fw_loaded and
 is_ram_script

On 2020/07/23 19:52 Frieder Schrempf <frieder.schrempf@...tron.de> wrote:
> 
> > The warning log comes out during spi
> > transfer start and sdma firmware loading done, but if sdma driver
> > building as module could ensure firmware loading done in
> > sdma_driver_probe_phase-> spi_imx_probe_phase, which means sdma
> > firmware loading has been ready before spi transfer start, hence no such
> warning message.
> >
> > But I am not sure if all client drivers except spi are in good shape
> > to support ' CONFIG_IMX_SDMA=m '.
> 
> I'm pretty sure that CONFIG_IMX_SDMA=m is supported and common.
> Otherwise it wouldn't be an option in Kconfig.
Sorry, I mean other drivers using sdma such as audio/uart..etc, I know
sdma driver support to build as module. But I'm not sure if there are some
potential issues here with changing to sdma module. For now, could we
just leave it for another patch whatever it's better solution or not?
> 
> > Besides, do you think 'dev_err_once ' instead of 'dev_err' is okay for you?
> 
> I can't really judge if this is a proper fix as I haven't looked at the code in detail,
> but if you want to use dev_err_once(), that would be ok for me, maybe even
> better dev_warn_once().
> As chances are that even without firmware transfers will work a warning
> instead of an error makes more sense to me.
Okay, I'll change it in later version. Anyway, thanks for your test.