linux-kernel - Re: [PATCH] habanalabs: Fix memory leak in error flow of context init

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAFCwf11+ZV1no4Sew8LU3sYh7V4wO=iwmPkohob9tbnBzOA-Og@mail.gmail.com>
Date:   Thu, 23 Jul 2020 17:21:22 +0300
From:   Oded Gabbay <oded.gabbay@...il.com>
To:     Tomer Tayar <ttayar@...ana.ai>
Cc:     "Linux-Kernel@...r. Kernel. Org" <linux-kernel@...r.kernel.org>,
        SW_Drivers@...ana.ai
Subject: Re: [PATCH] habanalabs: Fix memory leak in error flow of context init

On Thu, Jul 23, 2020 at 9:18 AM Tomer Tayar <ttayar@...ana.ai> wrote:
>
> Add a missing free of the cs_pending array in the error flow of context
> init.
>
> Fixes: 4b49c5b118b9 ("habanalabs: Use pending cs amount per asic")
>
> Signed-off-by: Tomer Tayar <ttayar@...ana.ai>
> ---
>  drivers/misc/habanalabs/common/context.c | 18 ++++++++++--------
>  1 file changed, 10 insertions(+), 8 deletions(-)
>
> diff --git a/drivers/misc/habanalabs/common/context.c b/drivers/misc/habanalabs/common/context.c
> index b75a20364fad..3e375958e73b 100644
> --- a/drivers/misc/habanalabs/common/context.c
> +++ b/drivers/misc/habanalabs/common/context.c
> @@ -138,36 +138,38 @@ int hl_ctx_init(struct hl_device *hdev, struct hl_ctx *ctx, bool is_kernel_ctx)
>                 rc = hl_mmu_ctx_init(ctx);
>                 if (rc) {
>                         dev_err(hdev->dev, "Failed to init mmu ctx module\n");
> -                       goto mem_ctx_err;
> +                       goto err_free_cs_pending;
>                 }
>         } else {
>                 ctx->asid = hl_asid_alloc(hdev);
>                 if (!ctx->asid) {
>                         dev_err(hdev->dev, "No free ASID, failed to create context\n");
> -                       return -ENOMEM;
> +                       rc = -ENOMEM;
> +                       goto err_free_cs_pending;
>                 }
>
>                 rc = hl_vm_ctx_init(ctx);
>                 if (rc) {
>                         dev_err(hdev->dev, "Failed to init mem ctx module\n");
>                         rc = -ENOMEM;
> -                       goto mem_ctx_err;
> +                       goto err_asid_free;
>                 }
>
>                 rc = hdev->asic_funcs->ctx_init(ctx);
>                 if (rc) {
>                         dev_err(hdev->dev, "ctx_init failed\n");
> -                       goto ctx_init_err;
> +                       goto err_vm_ctx_fini;
>                 }
>         }
>
>         return 0;
>
> -ctx_init_err:
> +err_vm_ctx_fini:
>         hl_vm_ctx_fini(ctx);
> -mem_ctx_err:
> -       if (ctx->asid != HL_KERNEL_ASID_ID)
> -               hl_asid_free(hdev, ctx->asid);
> +err_asid_free:
> +       hl_asid_free(hdev, ctx->asid);
> +err_free_cs_pending:
> +       kfree(ctx->cs_pending);
>
>         return rc;
>  }
> --
> 2.17.1
>
This patch is:
Reviewed-by: Oded Gabbay <oded.gabbay@...il.com>