[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20200723154209.GA423699@bogus>
Date: Thu, 23 Jul 2020 09:42:09 -0600
From: Rob Herring <robh@...nel.org>
To: Rahul Tanwar <rahul.tanwar@...ux.intel.com>
Cc: linux-kernel@...r.kernel.org, andriy.shevchenko@...el.com,
rahul.tanwar.linux@...il.com, songjun.Wu@...el.com,
linux-pwm@...r.kernel.org, thierry.reding@...il.com,
robh+dt@...nel.org, u.kleine-koenig@...gutronix.de,
cheol.yong.kim@...el.com, devicetree@...r.kernel.org,
qi-ming.wu@...el.com, p.zabel@...gutronix.de
Subject: Re: [PATCH v5 1/2] Add DT bindings YAML schema for PWM fan
controller of LGM SoC
On Thu, 23 Jul 2020 15:44:17 +0800, Rahul Tanwar wrote:
> Intel's LGM(Lightning Mountain) SoC contains a PWM fan controller
> which is only used to control the fan attached to the system. This
> PWM controller does not have any other consumer other than fan.
> Add DT bindings documentation for this PWM fan controller.
>
> Signed-off-by: Rahul Tanwar <rahul.tanwar@...ux.intel.com>
> ---
> .../devicetree/bindings/pwm/intel,lgm-pwm.yaml | 40 ++++++++++++++++++++++
> 1 file changed, 40 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/pwm/intel,lgm-pwm.yaml
>
My bot found errors running 'make dt_binding_check' on your patch:
/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/reset/intel,rcu-gw.example.dt.yaml: pwm@...00000: '#pwm-cells' does not match any of the regexes: 'pinctrl-[0-9]+'
/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/pwm/intel,lgm-pwm.example.dt.yaml: pwm@...00000: '#pwm-cells' is a required property
See https://patchwork.ozlabs.org/patch/1334579
If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure dt-schema is up to date:
pip3 install git+https://github.com/devicetree-org/dt-schema.git@master --upgrade
Please check and re-submit.
Powered by blists - more mailing lists