linux-kernel - Re: [PATCH v2][next] IB/hfi1: Use fallthrough pseudo-keyword

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 24 Jul 2020 17:01:43 -0300
From:   Jason Gunthorpe <jgg@...dia.com>
To:     "Gustavo A. R. Silva" <gustavoars@...nel.org>
CC:     Mike Marciniszyn <mike.marciniszyn@...el.com>,
        Dennis Dalessandro <dennis.dalessandro@...el.com>,
        Doug Ledford <dledford@...hat.com>,
        <linux-rdma@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2][next] IB/hfi1: Use fallthrough pseudo-keyword

On Tue, Jul 21, 2020 at 08:34:55AM -0500, Gustavo A. R. Silva wrote:
> Replace the existing /* fall through */ comments and its variants with
> the new pseudo-keyword macro fallthrough[1]. Also, remove unnecessary
> fall-through markings when it is the case.
> 
> [1] https://www.kernel.org/doc/html/v5.7-rc7/process/deprecated.html?highlight=fallthrough#implicit-switch-case-fall-through
> 
> Signed-off-by: Gustavo A. R. Silva <gustavoars@...nel.org>
> ---
> Changes in v2:
>  - Address fall-through markings in drivers/infiniband/hw/hfi1/chip.c
>    in a separate patch[2].
> 
>    [2] https://lore.kernel.org/lkml/20200709235250.GA26678@embeddedor/
> 
>  drivers/infiniband/hw/hfi1/firmware.c | 16 ----------------
>  drivers/infiniband/hw/hfi1/mad.c      |  9 ++++-----
>  drivers/infiniband/hw/hfi1/pio.c      |  2 +-
>  drivers/infiniband/hw/hfi1/pio_copy.c | 12 ++++++------
>  drivers/infiniband/hw/hfi1/platform.c | 10 +++++-----
>  drivers/infiniband/hw/hfi1/qp.c       |  2 +-
>  drivers/infiniband/hw/hfi1/qsfp.c     |  4 ++--
>  drivers/infiniband/hw/hfi1/rc.c       | 25 ++++++++++++-------------
>  drivers/infiniband/hw/hfi1/sdma.c     |  9 ++++-----
>  drivers/infiniband/hw/hfi1/tid_rdma.c |  4 ++--
>  drivers/infiniband/hw/hfi1/uc.c       |  8 ++++----
>  11 files changed, 41 insertions(+), 60 deletions(-)

Applied to for-next, thanks

Jason