linux-kernel - Re: [PATCH] octeontx2-af: Fix use of uninitialized pointer bmap

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 24 Jul 2020 16:57:22 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     dinghao.liu@....edu.cn
Cc:     kjlu@....edu, sgoutham@...vell.com, lcherian@...vell.com,
        gakula@...vell.com, jerinj@...vell.com, kuba@...nel.org,
        netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] octeontx2-af: Fix use of uninitialized pointer bmap

From: Dinghao Liu <dinghao.liu@....edu.cn>
Date: Fri, 24 Jul 2020 16:06:57 +0800

> If req->ctype does not match any of NIX_AQ_CTYPE_CQ,
> NIX_AQ_CTYPE_SQ or NIX_AQ_CTYPE_RQ, pointer bmap will remain
> uninitialized and be accessed in test_bit(), which can lead
> to kernal crash.

This can never happen.

> Fix this by returning an error code if this case is triggered.
> 
> Signed-off-by: Dinghao Liu <dinghao.liu@....edu.cn>

I strongly dislike changes like this.

Most callers of nix_lf_hwctx_disable() inside of rvu_nix.c set
req->ctype to one of the handled values.

The only other case, rvu_mbox_handler_nix_hwctx_disable(), is a
completely unused function and should be removed.

There is no functional problem in this code at all.

It is not possible show a code path where the stated problem can
actually occur.