linux-kernel - Re: [PATCH v5 bpf-next 5/5] selftests/bpf: add get_stackid_cannot

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20200724053220.dtega3r7i3jewgxx@ast-mbp.dhcp.thefacebook.com>
Date:   Thu, 23 Jul 2020 22:32:20 -0700
From:   Alexei Starovoitov <alexei.starovoitov@...il.com>
To:     Song Liu <songliubraving@...com>
Cc:     linux-kernel@...r.kernel.org, bpf@...r.kernel.org,
        netdev@...r.kernel.org, ast@...nel.org, daniel@...earbox.net,
        kernel-team@...com, john.fastabend@...il.com, kpsingh@...omium.org,
        brouer@...hat.com, peterz@...radead.org
Subject: Re: [PATCH v5 bpf-next 5/5] selftests/bpf: add
 get_stackid_cannot_attach

On Thu, Jul 23, 2020 at 11:06:48AM -0700, Song Liu wrote:
> +	pmu_fd = syscall(__NR_perf_event_open, &attr, -1 /* pid */,
> +			 0 /* cpu 0 */, -1 /* group id */,
> +			 0 /* flags */);
> +	if (pmu_fd < 0 && errno == ENOENT) {
> +		printf("%s:SKIP:cannot open PERF_COUNT_HW_CPU_CYCLES with precise_ip > 0\n",
> +		       __func__);
> +		test__skip();
> +		goto cleanup;
> +	}

That wasn't enough in my test VM.
I've changed it to be: (errno == ENOENT || errno == EOPNOTSUPP)
and applied the set.
Thanks