linux-kernel - Re: [f2fs-dev] [PATCH] f2fs: fix use-after-free issue

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <85b9af8d-0062-9c6b-0ad7-c48870a5cf2b@huawei.com>
Date:   Fri, 24 Jul 2020 09:22:11 +0800
From:   Chao Yu <yuchao0@...wei.com>
To:     Song Feng <songfengcn@....com>
CC:     <jaegeuk@...nel.org>, <linux-kernel@...r.kernel.org>,
        <linux-f2fs-devel@...ts.sourceforge.net>
Subject: Re: [f2fs-dev] [PATCH] f2fs: fix use-after-free issue

Hi Feng,

Thanks for the reminder. :)

Jaegeuk, could you please fix this while merging.

Thanks,

On 2020/7/23 23:26, Song Feng wrote:
> At 2020-07-23 17:28:06, "Chao Yu" <yuchao0@...wei.com> wrote:
> 
>> From: Li Guifu <bluce.liguifu@...wei.com>
>>
>> During umount, f2fs_put_super() unregisters procfs entries after
>> f2fs_destroy_segment_manager(), it may cause use-after-free
>> issue when umount races with procfs accessing, fix it by relcating
> typo issue: relcating -> relocating?
>> f2fs_unregister_sysfs().
>>
>> [Chao Yu: change commit title/message a bit]
>>
>> Signed-off-by: Li Guifu <bluce.liguifu@...wei.com>
>> Reviewed-by: Chao Yu <yuchao0@...wei.com>
>> Signed-off-by: Chao Yu <yuchao0@...wei.com>
>> ---
>> fs/f2fs/super.c | 5 +++--
>> 1 file changed, 3 insertions(+), 2 deletions(-)
>>
>> diff --git a/fs/f2fs/super.c b/fs/f2fs/super.c
>> index 80cb7cd358f8..bf8bd64c8380 100644
>> --- a/fs/f2fs/super.c
>> +++ b/fs/f2fs/super.c
>> @@ -1175,6 +1175,9 @@ static void f2fs_put_super(struct super_block *sb)
>> 	int i;
>> 	bool dropped;
>>
>> +	/* unregister procfs/sysfs entries to avoid race case */
>> +	f2fs_unregister_sysfs(sbi);
>> +
>> 	f2fs_quota_off_umount(sb);
>>
>> 	/* prevent remaining shrinker jobs */
>> @@ -1240,8 +1243,6 @@ static void f2fs_put_super(struct super_block *sb)
>>
>> 	kvfree(sbi->ckpt);
>>
>> -	f2fs_unregister_sysfs(sbi);
>> -
>> 	sb->s_fs_info = NULL;
>> 	if (sbi->s_chksum_driver)
>> 		crypto_free_shash(sbi->s_chksum_driver);
>> -- 
>> 2.26.2
>>
>>
>>
>> _______________________________________________
>> Linux-f2fs-devel mailing list
>> Linux-f2fs-devel@...ts.sourceforge.net
>> https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
> please check typo issue for comment: relcating->relocating?
>