linux-kernel - Re: [PATCH 1/3] x86/mm: Drop unused MAX_PHYSADDR

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <45ec14e7-fd5b-f4f9-6f61-94a9159ec3ad@redhat.com>
Date:   Fri, 24 Jul 2020 10:22:36 +0200
From:   David Hildenbrand <david@...hat.com>
To:     Arvind Sankar <nivedita@...m.mit.edu>, x86@...nel.org,
        Dave Hansen <dave.hansen@...ux.intel.com>,
        Andy Lutomirski <luto@...nel.org>,
        Peter Zijlstra <peterz@...radead.org>,
        linux-sh@...r.kernel.org,
        Yoshinori Sato <ysato@...rs.sourceforge.jp>,
        Rich Felker <dalias@...c.org>, sparclinux@...r.kernel.org,
        "David S. Miller" <davem@...emloft.net>
Cc:     Andrew Morton <akpm@...ux-foundation.org>, linux-mm@...ck.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/3] x86/mm: Drop unused MAX_PHYSADDR_BITS

On 24.07.20 01:15, Arvind Sankar wrote:
> The macro is not used anywhere, and has an incorrect value (going by the
> comment) on x86_64 since commit
>   c898faf91b3e ("x86: 46 bit physical address support on 64 bits")
> 
> To avoid confusion, just remove the definition.
> 
> Signed-off-by: Arvind Sankar <nivedita@...m.mit.edu>
> ---
>  arch/x86/include/asm/sparsemem.h | 6 +-----
>  1 file changed, 1 insertion(+), 5 deletions(-)
> 
> diff --git a/arch/x86/include/asm/sparsemem.h b/arch/x86/include/asm/sparsemem.h
> index 199218719a86..6bfc878f6771 100644
> --- a/arch/x86/include/asm/sparsemem.h
> +++ b/arch/x86/include/asm/sparsemem.h
> @@ -10,24 +10,20 @@
>   *    field of the struct page
>   *
>   * SECTION_SIZE_BITS		2^n: size of each section
> - * MAX_PHYSADDR_BITS		2^n: max size of physical address space
> - * MAX_PHYSMEM_BITS		2^n: how much memory we can have in that space
> + * MAX_PHYSMEM_BITS		2^n: max size of physical address space
>   *
>   */
>  
>  #ifdef CONFIG_X86_32
>  # ifdef CONFIG_X86_PAE
>  #  define SECTION_SIZE_BITS	29
> -#  define MAX_PHYSADDR_BITS	36
>  #  define MAX_PHYSMEM_BITS	36
>  # else
>  #  define SECTION_SIZE_BITS	26
> -#  define MAX_PHYSADDR_BITS	32
>  #  define MAX_PHYSMEM_BITS	32
>  # endif
>  #else /* CONFIG_X86_32 */
>  # define SECTION_SIZE_BITS	27 /* matt - 128 is convenient right now */
> -# define MAX_PHYSADDR_BITS	(pgtable_l5_enabled() ? 52 : 44)
>  # define MAX_PHYSMEM_BITS	(pgtable_l5_enabled() ? 52 : 46)
>  #endif
>  
> 

Reviewed-by: David Hildenbrand <david@...hat.com>

-- 
Thanks,

David / dhildenb