linux-kernel - Re: [PATCH -next] arm64: Export __cpu_logical_map

Open Source and information security mailing list archives

Date:   Fri, 24 Jul 2020 17:16:45 +0800
From:   Kefeng Wang <wangkefeng.wang@...wei.com>
To:     Anshuman Khandual <anshuman.khandual@....com>,
        Catalin Marinas <catalin.marinas@....com>,
        Will Deacon <will@...nel.org>,
        Mikko Perttunen <mperttunen@...dia.com>,
        Sumit Gupta <sumitg@...dia.com>,
        Viresh Kumar <viresh.kumar@...aro.org>
CC:     Hulk Robot <hulkci@...wei.com>,
        "linux-kernel@...r.kernel.org List" <linux-kernel@...r.kernel.org>,
        <linux-arm-kernel@...ts.infradead.org>
Subject: Re: [PATCH -next] arm64: Export __cpu_logical_map

On 2020/7/24 16:16, Anshuman Khandual wrote:
> On 07/24/2020 08:38 AM, Kefeng Wang wrote:
>> +maillist
> This does not seem to be a correct method of posting any patch.
sorry， forget to cc mailist when git send-email
>> On 2020/7/24 11:04, Kefeng Wang wrote:
>>> ERROR: modpost: "__cpu_logical_map" [drivers/cpufreq/tegra194-cpufreq.ko] undefined!
>
>>> ARM64 tegra194-cpufreq driver use cpu_logical_map, export
>>> __cpu_logical_map to fix build issue.
> Commit 887d5fc82cb4 ("cpufreq: Add Tegra194 cpufreq driver") which adds
> this particular driver is present just on linux-next. But as expected,
> the driver does not use __cpu_logical_map directly but instead accesses
> it via cpu_logical_map() wrapper. Wondering, how did you even trigger
> the modpost error ?

arch/arm64/include/asm/smp.h:#define cpu_logical_map(cpu) 
__cpu_logical_map[cpu]

Will see the error when using allmodconfig to build.

>
>>> Reported-by: Hulk Robot <hulkci@...wei.com>
>>> Signed-off-by: Kefeng Wang <wangkefeng.wang@...wei.com>
>>> ---
>>>    arch/arm64/kernel/setup.c | 1 +
>>>    1 file changed, 1 insertion(+)
>>>
>>> diff --git a/arch/arm64/kernel/setup.c b/arch/arm64/kernel/setup.c
>>> index c793276ec7ad9..3aea05fbb9998 100644
>>> --- a/arch/arm64/kernel/setup.c
>>> +++ b/arch/arm64/kernel/setup.c
>>> @@ -275,6 +275,7 @@ static int __init reserve_memblock_reserved_regions(void)
>>>    arch_initcall(reserve_memblock_reserved_regions);
>>>      u64 __cpu_logical_map[NR_CPUS] = { [0 ... NR_CPUS-1] = INVALID_HWID };
>>> +EXPORT_SYMBOL(__cpu_logical_map);
>>>      void __init setup_arch(char **cmdline_p)
>>>    {
>>
>> _______________________________________________
>> linux-arm-kernel mailing list
>> linux-arm-kernel@...ts.infradead.org
>> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
>>
> .
>

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives