linux-kernel - Re: [PATCH] mtd: rawnand: oxnas: cleanup/simplify code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <7037f4aa-6b6d-9354-ab4a-261dd754312e@baylibre.com>
Date:   Fri, 24 Jul 2020 12:01:53 +0200
From:   Neil Armstrong <narmstrong@...libre.com>
To:     Pavel Machek <pavel@....cz>, trivial@...nel.org,
        miquel.raynal@...tlin.com, richard@....at, vigneshr@...com,
        nishkadg.linux@...il.com, linux-mtd@...ts.infradead.org,
        linux-arm-kernel@...ts.infradead.org, linux-oxnas@...ups.io,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] mtd: rawnand: oxnas: cleanup/simplify code

On 24/07/2020 10:38, Pavel Machek wrote:
> Simplify oxnas_nand_probe.
> 
> Signed-off-by: Pavel Machek (CIP) <pavel@...x.de>
> 
> diff --git a/drivers/mtd/nand/raw/oxnas_nand.c b/drivers/mtd/nand/raw/oxnas_nand.c
> index 8d0d76ad319d..f44947043e5a 100644
> --- a/drivers/mtd/nand/raw/oxnas_nand.c
> +++ b/drivers/mtd/nand/raw/oxnas_nand.c
> @@ -144,8 +144,7 @@ static int oxnas_nand_probe(struct platform_device *pdev)
>  		if (err)
>  			goto err_cleanup_nand;
>  
> -		oxnas->chips[oxnas->nchips] = chip;
> -		++oxnas->nchips;
> +		oxnas->chips[oxnas->nchips++] = chip;
>  	}
>  
>  	/* Exit if no chips found */
> 

Acked-by: Neil Armstrong <narmstrong@...libre.com>



Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)