linux-kernel - RE: [PATCH] soundwire: master: enable pm runtime

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <DM6PR11MB40743347C935B5B24F278A59FF770@DM6PR11MB4074.namprd11.prod.outlook.com>
Date:   Fri, 24 Jul 2020 11:09:12 +0000
From:   "Liao, Bard" <bard.liao@...el.com>
To:     Greg KH <gregkh@...uxfoundation.org>,
        Bard Liao <yung-chuan.liao@...ux.intel.com>
CC:     "alsa-devel@...a-project.org" <alsa-devel@...a-project.org>,
        "vkoul@...nel.org" <vkoul@...nel.org>,
        "vinod.koul@...aro.org" <vinod.koul@...aro.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "tiwai@...e.de" <tiwai@...e.de>,
        "broonie@...nel.org" <broonie@...nel.org>,
        "jank@...ence.com" <jank@...ence.com>,
        "srinivas.kandagatla@...aro.org" <srinivas.kandagatla@...aro.org>,
        "rander.wang@...ux.intel.com" <rander.wang@...ux.intel.com>,
        "ranjani.sridharan@...ux.intel.com" 
        <ranjani.sridharan@...ux.intel.com>,
        "hui.wang@...onical.com" <hui.wang@...onical.com>,
        "pierre-louis.bossart@...ux.intel.com" 
        <pierre-louis.bossart@...ux.intel.com>,
        "Kale, Sanyog R" <sanyog.r.kale@...el.com>,
        "Lin, Mengdong" <mengdong.lin@...el.com>
Subject: RE: [PATCH] soundwire: master: enable pm runtime

> -----Original Message-----
> From: Greg KH <gregkh@...uxfoundation.org>
> Sent: Friday, July 24, 2020 4:32 PM
> To: Bard Liao <yung-chuan.liao@...ux.intel.com>
> Cc: alsa-devel@...a-project.org; vkoul@...nel.org; vinod.koul@...aro.org;
> linux-kernel@...r.kernel.org; tiwai@...e.de; broonie@...nel.org;
> jank@...ence.com; srinivas.kandagatla@...aro.org;
> rander.wang@...ux.intel.com; ranjani.sridharan@...ux.intel.com;
> hui.wang@...onical.com; pierre-louis.bossart@...ux.intel.com; Kale, Sanyog
> R <sanyog.r.kale@...el.com>; Lin, Mengdong <mengdong.lin@...el.com>;
> Liao, Bard <bard.liao@...el.com>
> Subject: Re: [PATCH] soundwire: master: enable pm runtime
> 
> On Thu, Jul 23, 2020 at 09:49:02PM +0800, Bard Liao wrote:
> > We should enable pm runtime.
> 
> Because why?

The hierarchy of soundwire devices is platform device -> M device -> S
device. A S device is physically attached on the platform device. So the
platform device should be resumed when a S device is resumed. As the
bridge of platform device and S device, we have to implement runtime pm
on M driver. We have set runtime pm ops in M driver already, but still
need to enable runtime pm.

> 
> Please read the documentation about how to write good changelog
> comments...

Sure. I will update the changelog in next version. Thanks for the advice.

> 
> greg k-h