linux-kernel - Re: [PATCH] MIPS: BCM63xx: improve CFE version detection

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20200724110948.GB17183@alpha.franken.de>
Date:   Fri, 24 Jul 2020 13:09:48 +0200
From:   Thomas Bogendoerfer <tsbogend@...ha.franken.de>
To:     Álvaro Fernández Rojas <noltari@...il.com>
Cc:     f.fainelli@...il.com, jonas.gorski@...il.com,
        bcm-kernel-feedback-list@...adcom.com, linux-mips@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] MIPS: BCM63xx: improve CFE version detection

On Mon, Jun 08, 2020 at 11:28:35AM +0200, Álvaro Fernández Rojas wrote:
> There are some CFE variants that start with 'cfe-vd' instead of 'cfe-v', such
> as the one used in the Huawei HG556a: "cfe-vd081.5003". In this case, the CFE
> version is stored as is (string vs number bytes).
> 
> Some newer devices have an additional version number, such as the Comtrend
> VR-3032u: "1.0.38-112.118-11".
> 
> Finally, print the string as is if the version doesn't start with "cfe-v" or
> "cfe-vd", but starts with "cfe-".
> 
> Signed-off-by: Álvaro Fernández Rojas <noltari@...il.com>
> ---
>  arch/mips/bcm63xx/boards/board_bcm963xx.c | 22 ++++++++++++++++++----
>  1 file changed, 18 insertions(+), 4 deletions(-)

applied to mips-next.

Thomas.

-- 
Crap can work. Given enough thrust pigs will fly, but it's not necessarily a
good idea.                                                [ RFC1925, 2.3 ]