linux-kernel - Re: [PATCH 1/2] Bluetooth: hci_h5: Set HCI_UART_RESET_ON

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <6c76582e-5e5d-0977-37b6-82bc84bd81c9@redhat.com>
Date:   Fri, 24 Jul 2020 13:49:55 +0200
From:   Hans de Goede <hdegoede@...hat.com>
To:     Nicolas Boichat <drinkcat@...omium.org>,
        Marcel Holtmann <marcel@...tmann.org>
Cc:     Johan Hedberg <johan.hedberg@...il.com>,
        linux-bluetooth@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/2] Bluetooth: hci_h5: Set HCI_UART_RESET_ON_INIT to
 correct flags

Hi,

On 7/21/20 4:37 AM, Nicolas Boichat wrote:
> HCI_UART_RESET_ON_INIT belongs in hdev_flags, not flags.
> 
> Fixes: ce945552fde4a09 ("Bluetooth: hci_h5: Add support for serdev enumerated devices")
> Signed-off-by: Nicolas Boichat <drinkcat@...omium.org>

Patch looks good to me:

Reviewed-by: Hans de Goede <hdegoede@...hat.com>

Regards,

Hans




> 
> ---
> 
>   drivers/bluetooth/hci_h5.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/bluetooth/hci_h5.c b/drivers/bluetooth/hci_h5.c
> index e60b2e0773db110..e41854e0d79aae2 100644
> --- a/drivers/bluetooth/hci_h5.c
> +++ b/drivers/bluetooth/hci_h5.c
> @@ -793,7 +793,7 @@ static int h5_serdev_probe(struct serdev_device *serdev)
>   	if (!h5)
>   		return -ENOMEM;
>   
> -	set_bit(HCI_UART_RESET_ON_INIT, &h5->serdev_hu.flags);
> +	set_bit(HCI_UART_RESET_ON_INIT, &h5->serdev_hu.hdev_flags);
>   
>   	h5->hu = &h5->serdev_hu;
>   	h5->serdev_hu.serdev = serdev;
>