linux-kernel - security/integrity/platform_certs/keyring_handler.c:62:30: warning: no previous prototype for 'get_handler_for

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:   Fri, 24 Jul 2020 09:39:32 +0800
From:   kernel test robot <lkp@...el.com>
To:     Nayna Jain <nayna@...ux.ibm.com>
Cc:     kbuild-all@...ts.01.org, linux-kernel@...r.kernel.org,
        Michael Ellerman <mpe@...erman.id.au>,
        Eric Richter <erichte@...ux.ibm.com>
Subject: security/integrity/platform_certs/keyring_handler.c:62:30: warning:
 no previous prototype for 'get_handler_for_db'

Hi Nayna,

FYI, the error/warning still remains.

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head:   d15be546031cf65a0fc34879beca02fd90fe7ac7
commit: ad723674d6758478829ee766e3f1a2a24d56236f x86/efi: move common keyring handler functions to new file
date:   9 months ago
config: ia64-randconfig-r025-20200723 (attached as .config)
compiler: ia64-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        git checkout ad723674d6758478829ee766e3f1a2a24d56236f
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=ia64 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@...el.com>

All warnings (new ones prefixed by >>):

   In file included from arch/ia64/include/asm/pgtable.h:154,
                    from include/linux/mm.h:99,
                    from arch/ia64/include/asm/uaccess.h:38,
                    from include/linux/uaccess.h:11,
                    from arch/ia64/include/asm/sections.h:11,
                    from include/linux/interrupt.h:20,
                    from include/linux/rtc.h:17,
                    from include/linux/efi.h:20,
                    from security/integrity/platform_certs/keyring_handler.c:7:
   arch/ia64/include/asm/mmu_context.h: In function 'reload_context':
   arch/ia64/include/asm/mmu_context.h:137:41: warning: variable 'old_rr4' set but not used [-Wunused-but-set-variable]
     137 |  unsigned long rr0, rr1, rr2, rr3, rr4, old_rr4;
         |                                         ^~~~~~~
   security/integrity/platform_certs/keyring_handler.c: At top level:
>> security/integrity/platform_certs/keyring_handler.c:62:30: warning: no previous prototype for 'get_handler_for_db' [-Wmissing-prototypes]
      62 | __init efi_element_handler_t get_handler_for_db(const efi_guid_t *sig_type)
         |                              ^~~~~~~~~~~~~~~~~~
>> security/integrity/platform_certs/keyring_handler.c:73:30: warning: no previous prototype for 'get_handler_for_dbx' [-Wmissing-prototypes]
      73 | __init efi_element_handler_t get_handler_for_dbx(const efi_guid_t *sig_type)
         |                              ^~~~~~~~~~~~~~~~~~~

vim +/get_handler_for_db +62 security/integrity/platform_certs/keyring_handler.c

    57	
    58	/*
    59	 * Return the appropriate handler for particular signature list types found in
    60	 * the UEFI db and MokListRT tables.
    61	 */
  > 62	__init efi_element_handler_t get_handler_for_db(const efi_guid_t *sig_type)
    63	{
    64		if (efi_guidcmp(*sig_type, efi_cert_x509_guid) == 0)
    65			return add_to_platform_keyring;
    66		return 0;
    67	}
    68	
    69	/*
    70	 * Return the appropriate handler for particular signature list types found in
    71	 * the UEFI dbx and MokListXRT tables.
    72	 */
  > 73	__init efi_element_handler_t get_handler_for_dbx(const efi_guid_t *sig_type)

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

Download attachment ".config.gz" of type "application/gzip" (24521 bytes)