[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20200724125514.GD3399@localhost.localdomain>
Date: Fri, 24 Jul 2020 09:55:14 -0300
From: Marcelo Ricardo Leitner <marcelo.leitner@...il.com>
To: Colin King <colin.king@...onical.com>
Cc: Vlad Yasevich <vyasevich@...il.com>,
Neil Horman <nhorman@...driver.com>,
"David S . Miller" <davem@...emloft.net>,
Jakub Kicinski <kuba@...nel.org>, linux-sctp@...r.kernel.org,
netdev@...r.kernel.org, kernel-janitors@...r.kernel.org,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH] sctp: remove redundant initialization of variable status
On Fri, Jul 24, 2020 at 01:17:53PM +0100, Colin King wrote:
> From: Colin Ian King <colin.king@...onical.com>
>
> The variable status is being initialized with a value that is never read
> and it is being updated later with a new value. The initialization is
> redundant and can be removed.
>
> Addresses-Coverity: ("Unused value")
> Signed-off-by: Colin Ian King <colin.king@...onical.com>
Acked-by: Marcelo Ricardo Leitner <marcelo.leitner@...il.com>
Are you willing to send another to patch to fix the var ordering in
reverse christmass tree in there?
> ---
> net/sctp/protocol.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/net/sctp/protocol.c b/net/sctp/protocol.c
> index 7ecaf7d575c0..a0448f7c64b9 100644
> --- a/net/sctp/protocol.c
> +++ b/net/sctp/protocol.c
> @@ -1368,7 +1368,7 @@ static struct pernet_operations sctp_ctrlsock_ops = {
> static __init int sctp_init(void)
> {
> int i;
> - int status = -EINVAL;
> + int status;
> unsigned long goal;
> unsigned long limit;
> unsigned long nr_pages = totalram_pages();
> --
> 2.27.0
>
Powered by blists - more mailing lists